Comments (16)
/assignme
from openraft.
OKk, when #49 and #61 is over, l will start.
from openraft.
👋 Thanks for opening this issue!
Get help or engage by:
/help
: to print help messages./assignme
: to assign this issue to you.
from openraft.
what i understand is pre-appened a membership log at index 0,with term 0 that helpful for the cluster first startup, as your said we don't need to judge last_log_index
.
But not first startup, even if add this index 0 term 0 log , it will be skipped without any impact
Right?
from openraft.
But not first startup, even if add this index 0 term 0 log , it will be skipped without any impact
Right?
If a node has received any log from some Leader, when starting up it has not to add a log at (0,0);
If a node has no logs at all, when initialize(members)
is called, it should add a membership log at (0,0);
from openraft.
Okk,i seem to understand.
from openraft.
@eliasyaoyc
I am not fully sure this issue can be done before #49 and #61 are done. 🤔
from openraft.
today or tomorrow.
from openraft.
today or tomorrow.
I mean, this issue may be affected by the changes introduced by #49 and #61
from openraft.
general plan, add a param on RaftInner
.
when RaftCore::spanw
called, then get_log_state
will used that determine this node whether received any log.
no log mark this param is true, then identify this param to determine whether to send term 0,index 0 log.
from openraft.
What is the name of param that will be added? Since IMO, it could always read the state from storage without the help of other additional fields.
Currently, the implementation adds a blank log entry at term:0, index:0, so that the initial value of such as last_log_id
is valid.
I've been trying to remove this initial log term:0,index:0
. After these get merged, it'd be simpler to get this issue done.
from openraft.
What is the name of param that will be added? Since IMO, it could always read the state from storage without the help of other additional fields.
I don't know how to notify initialize(members)
that needs to add a term:0, index:0
log without additional field.
from openraft.
self.core.last_log_id.is_none()
would be enough to ensure it is a uninitialized node I think 🤔
from openraft.
yes, last_log.is_none()
can complete this work.
but initialize(members)
haven't core reference.
pub fn new(id: NodeId, config: Arc<Config>, network: Arc<N>, storage: Arc<S>) -> Self {
...
let raft_handle = RaftCore::spawn(id, config, network, storage, rx_api, tx_metrics, rx_shutdown);
...
}
pub async fn initialize(&self, members: BTreeSet<NodeId>) -> Result<(), InitializeError> {
let (tx, rx) = oneshot::channel();
self.call_core(RaftMsg::Initialize { members, tx }, rx).await
}
Is there something wrong with my understanding? 😭
from openraft.
These should be done in handle_init_with_config()
.
I've get this done in: https://github.com/datafuselabs/openraft/pull/107/files#diff-2b96982d340b2d4f989026d55516c495678f2320fe05d2841c65748f52c42ff5
from openraft.
- fixed in #107
from openraft.
Related Issues (20)
- Feature: Monoio Runtime HOT 3
- Add sync primitives to `AsyncRuntime` trait HOT 1
- Add `AsyncRuntime::oneshot` HOT 2
- Propose stream-based Replication of Log Entries HOT 2
- Dynamic Cluster Membership HOT 5
- Release 0.9 HOT 2
- Killing the leader of a cluster generates excessive network attempts for replicating log entries HOT 4
- RFC: Client request pipelining HOT 9
- main branch cannot compile, please update dependency rocksdb version HOT 2
- move trait method: from `RaftLogStorage` to `RaftLogReader::read_vote()` HOT 2
- Implement TryAsRef<ForwardToLeader<..>> for RaftError HOT 3
- When quitting, RaftCore outputs unexpected ERROR log HOT 1
- Proposal: Remove `RaftLogReader` Trait Dependency from `RaftLogStorage` HOT 2
- Move examples into the workspace HOT 1
- Install Snapshot v1 api HOT 3
- Observe state changes in a Raft node HOT 6
- Split metrics into data metrics and server metrics HOT 5
- About automatic remove HOT 3
- Backing up the WAL HOT 6
- Raft Core Panicking HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openraft.