Comments (9)
/assignme
from openraft.
get~ thanks XD
from openraft.
👋 Thanks for opening this issue!
Get help or engage by:
/help
: to print help messages./assignme
: to assign this issue to you.
from openraft.
Hi, I have a question, the old last_id_in_log
method will return a LogId
,not an Option<LogId>
, but the new one we should return an Option
. I found I need to call unwrap_or_default()
every time I want to get the last_log_id
. Shall we replace the return type of get_log_state
method to Result<(Option<LogId>, LogId), StorageError>
? @drmingdrmer
from openraft.
There are some corner cases with using LogId for last_log_id.
E.g., when there is no log at all, using LogId
, it returns (0,0)
, which will confuse the caller.
unwrap()
everywhere, for now, is not a big deal. As soon as the main branch merges #49 , it will work smoothly altogether.
from openraft.
@YangKian hi, this issue may have a strong connection with #49 , it seems difficult to finish each one alone, so do you want to combine these two issues into one pr to fix them or any other advice?
from openraft.
@Veeupup Sorry for the late reply. Is it blocking something on your side? It seems to be working fine on my side, at least the tests passed after the changes were made, if I'm not missing something. I'll fill the pr later, and if my side is blocking your progress, it's ok to leave it to me XD
from openraft.
@YangKian yeah, u can finish it later. from my side, it will make nonsense if last_id_in_log()
and some function return LogId
ranther than Option<LogId>
.
from openraft.
@Veeupup Ok, let me handle it~
from openraft.
Related Issues (20)
- main branch cannot compile, please update dependency rocksdb version HOT 2
- move trait method: from `RaftLogStorage` to `RaftLogReader::read_vote()` HOT 2
- Implement TryAsRef<ForwardToLeader<..>> for RaftError HOT 3
- When quitting, RaftCore outputs unexpected ERROR log HOT 1
- Proposal: Remove `RaftLogReader` Trait Dependency from `RaftLogStorage` HOT 2
- What operations can run at the same time ? HOT 3
- unrecognized feature for crate openraft: type-alias HOT 3
- semi-async `RaftLogReader::try_get_log_entries` HOT 3
- Non-blocking `RaftStateMachine::apply()` HOT 5
- `AsyncRuntime::unbounded_mpsc` HOT 2
- `AsyncRuntime::watch` HOT 3
- Update quickstart to include Responder for RaftTypeConfig HOT 2
- Mention `server_metrics()` and `data_metrics()` in `FAQ How to get notified when the server state changes` HOT 1
- Metrics: add last acked heartbeat timestamp for each follower/learner HOT 2
- Timekeeping in standard units HOT 3
- Generalize `AnyError` HOT 1
- Direction towards allocation-free operations HOT 22
- Change a voter to learner should not affect existing learners. HOT 1
- Uniform `AsyncRuntime` channel interfaces HOT 2
- Add test suite to ensure the correctness of `AsyncRuntime` implementation. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openraft.