Comments (7)
Yes there were some discussions about that already and yes we want to change that behavior. Can't say when exactly it'll happen tho but I think it's safe to assume this change will make it into release 1.2.
from dm-core.
Is there any reason why someone should be relying on the current behaviour with an invalid query?
It would seem that changing this would only make it less likely that people are hitting cases where their queries are not actually executed.
from dm-core.
@solnic, @emmanuel. Id like to tackle this since I was bid by this multiple times. It has become better since we merged the "raise on invalid property" patches but you can still easily create an invalid query. You'll accept a pull request for 1.3?
from dm-core.
@mbj sure man!
from dm-core.
@mbj Any interest in tackling this still?
from dm-core.
Oh wait, I did add a PR … #295.
from dm-core.
@mbj Any interest in tackling this still?
No, sorry.
from dm-core.
Related Issues (20)
- Bug on create unique index with scopes HOT 3
- Bump RSpec for Tests HOT 1
- Requirements missing? HOT 2
- DataMapper::Resource#run_once isn't thread-safe (and raises in remove_instance_variable) HOT 3
- Order clause is broken - +options[:order]+ entry #<Origin::Key:0x00000004c1bc50...> of an unsupported object Origin::Key (ArgumentError) HOT 1
- Non-primary key Serial property HOT 2
- Failed to setup DB with some ASCII characters in file path HOT 1
- Support raw data types HOT 1
- Datamapper SQL syntax error: argument passed to method computed as single quote instead of value HOT 5
- There should be a nice DSL for self.default_repository_name HOT 1
- Low performance on RPI2 HOT 1
- Extract dm-core/spec/* to a standalone gem
- Use array of hashes to populate `has n` dependency generates exceptions HOT 1
- Most types in dm-core inherit from Object, then overwrite dump/load with a module
- `require': cannot load such file -- dm-sqlote3-adapter
- Alternate use of eql as i'm getting `explicit use of 'eql' operator is deprecated ` error
- dm-serializer-1.2.2 dependencies HOT 1
- dm-serializer-1.2.2 dependency update HOT 2
- Unable to fetch belongs_to association in loop
- Offtopic: troubles on official site. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dm-core.