Giter Site home page Giter Site logo

Comments (7)

solnic avatar solnic commented on June 29, 2024

Yes there were some discussions about that already and yes we want to change that behavior. Can't say when exactly it'll happen tho but I think it's safe to assume this change will make it into release 1.2.

from dm-core.

halorgium avatar halorgium commented on June 29, 2024

Is there any reason why someone should be relying on the current behaviour with an invalid query?
It would seem that changing this would only make it less likely that people are hitting cases where their queries are not actually executed.

from dm-core.

mbj avatar mbj commented on June 29, 2024

@solnic, @emmanuel. Id like to tackle this since I was bid by this multiple times. It has become better since we merged the "raise on invalid property" patches but you can still easily create an invalid query. You'll accept a pull request for 1.3?

from dm-core.

solnic avatar solnic commented on June 29, 2024

@mbj sure man!

from dm-core.

tpitale avatar tpitale commented on June 29, 2024

@mbj Any interest in tackling this still?

from dm-core.

tpitale avatar tpitale commented on June 29, 2024

Oh wait, I did add a PR … #295.

from dm-core.

mbj avatar mbj commented on June 29, 2024

@mbj Any interest in tackling this still?

No, sorry.

from dm-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.