Overwriting default_scope conditions is broken

[datamapper]

Overwriting default_scope conditions is broken

[solnic]

I can confirm that this issue is reproducible on 0.10.2 and on master branch.

by Marcin Kulik

[solnic]

It’s a private API so the ticket should be treated more like a suggestion to make the default_scope a public method and of course make it work correctly.

by Piotr Solnica (solnic)

[solnic]

yeah, generally I name my private API methods as something a bit longer/uglier than I normally would for a public method. In this case what I’d probably do is make a "scope" method, mark it as public and make that part of the API.

The other thing I would like to do with the scope behaviour is make it so that the default scope is used for property defaults. So like in the above case if you did:

user = User.create
user.active  # => true (rather than nil)

This behaviour is consistent with how Collection works now, eg:

# NOTE: assume there is no default scope

user = User.all(:active => true).create
user.active  # => true

by Dan Kubb (dkubb)

[solnic]

With or without using it for property defaults, it’s still VERY useful and my apps strongly rely on it. I’d love to see it in public API.

by Marcin Kulik

[solnic]

I like default_scope too.

by komagata (at gmail)