Giter Site home page Giter Site logo

Comments (8)

AllanJard avatar AllanJard commented on June 26, 2024 1

Thanks! Yes, I'll look into this. Having some form of diacritic support built into DataTables is something I want to add, so I'll look into this when I do that. Can't be certain when that will be though...

from plugins.

AllanJard avatar AllanJard commented on June 26, 2024 1

Thank you for the test case! The fix is fairly straight forward - we need to tell DataTables to use localeCompare rather than straight character number sorting. That can be done with the new DataTable.type() method:

DataTable.type('string', 'order', {
  asc: function (a, b) {
    return a.localeCompare(b);
  },
  desc: function (a, b) {
    return b.localeCompare(a);
  }
});

Example here: https://live.datatables.net/dayodoli/3/edit .

You'd need to do similar for html data type as well if you needed that.

Should DataTables do that by default? Very possibly. I didn't include it a while back because of the impact on performance. That might have changed with updates to the Javascript engines. I'll look into it again.

edited Fix from below.

from plugins.

toxpal avatar toxpal commented on June 26, 2024

The same applies for sorting plugin - if diacritics sort plugin is used, it only works fro string columns. If column contains any HTML data, diacritics sorting doesn't work.

from plugins.

AllanJard avatar AllanJard commented on June 26, 2024

DataTables 2 effectively has this ability built in. This plug-in is no longer useful. If you are having problems with that ability, please link to a test case showing the issue.

from plugins.

toxpal avatar toxpal commented on June 26, 2024

Yes, DT 2.0 has diacritics filtering built-in, and it works perfectly! Unfortunately, that doesn't apply to sorting, so I still have to use this plugin - https://datatables.net/plug-ins/sorting/diacritics-sort. Unfortunately, plugin doesn't work if column contains HTML data.

Here's an example using DT2 - https://live.datatables.net/dayodoli/1/edit

See "Name" column, which contains names with diacritics. In default state, names are sorted alphabetically. However, when names get sorted alphabetically by DT, sorting is wrong because DT orders names without diacritics first, and moves names with diacritics to the bottom.

If I add sorting plugin, it works as long as column with names doesn't have any HTML tags. Once HTML is added to some rows, ordering doesn't work again.

from plugins.

toxpal avatar toxpal commented on June 26, 2024

Thanks for the example. I just want to let you know that code for desc contains a small typo and should be return b.localeCompare(a); (otherwise sorting descending will change nothing and items will be sorted ascending)

from plugins.

AllanJard avatar AllanJard commented on June 26, 2024

Doh - good point! I've updated my post in case anyone else gets caught by that.

from plugins.

toxpal avatar toxpal commented on June 26, 2024

By the way, I'm not sure if you are aware that adding data-order tag prevents diacritics filter from working. See example here - https://live.datatables.net/dayodoli/4/edit - I just added data-order attribute to names, and diacritics filter doesn't work. In fact, even if you enter whole name correctly (with or without diacritics) into search field, DT2 can't find it.

I use a workaround now: add some random string to data-order attribute. For example, if I change data-order="1" to data-order="random-1", filtering starts working again.

from plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.