Datree offline mode is still reaching out to the internet

[adamdepollo]

Datree offline mode is still reaching out to the internet

[royhadad]

Here to shed some light on this issue 👋

The following command datree config set offline local only tells the Datree CLI what to do once it detects there is no internet connection.
The datree CLI detects a network error, and only if one is detected will it go offline.
A network error is detected in this code block

Because your network-blocking software returns a modified (and different) network error than expected, Datree does not switch to offline mode.

A quick possible patch could be to add your particular error (or some distinguishing part of it) to the errors array in the code block mentioned:
Maybe "Web Page Blocked" or "blocked" (case-insensitive)?

datree/pkg/utils/errors.go

Line 21 in dc462f5

networkErrors := []string{"network error", "connection refused", "no such host", "i/o timeout", "server misbehaving"}

This is an open-source project, pull requests are welcomed :)

[adamdepollo]

@romanlab I believe I just grabbed the binary from the releases page.

@royhadad OK, thanks for that clarification. I will try to work on a pull request this week for the fix you suggested.

Though I wonder about the functionality of that offline option ... seems like there could theoretically be any number of error messages thrown depending on what network configurations folks have. Wouldn't it make more sense to just skip any outbound calls when the offline flag is on rather than wait for an error to happen?

[hadar-co]

related to: #746

[adifayer]

@adamdepollo Thank you for opening this issue, we will prioritize it soon and update here once we start developing the solution :)

[romanlab]

@adamdepollo i noticed the url is pointing to our staging environment. How did you download the version you're using?

[romanlab]

@adamdepollo It's best to download via one of our install methods but if you want to use a binary from the releases, make sure you don't use one of the -rc releases as they point to our staging environment and may be less stable to use.

[adamdepollo]

@romanlab Ah OK good to know, I think I did pull the rc one originally but unfortunately having the same issue with the stable version :(