bug: `let!` macro doesn't work in loop

[datwaft]

bug: `let!` macro doesn't work in loop

[datwaft]

This is kind of intended.

I talked about this with zest creator here.

The problem is a limitation of macros, because they work on compilation time they cannot evaluate their parameters to know if a symbol (like b in your case) is a vim variable name or a local name (maybe it could be posible to read the local environment using a macro (I have seen it in fennel's documentation), but it would make the macro overly complicated).

Therefore, I needed to decide between using symbols as vim variables and not accepting runtime variables as names, or using strings and having the ability to do that.

Option 1:

(let! spell true)
(let [spell "wrap"]
  (let! spell true)) ; this sets spell, not wrap

Option 2:

(let! :spell true) ; now you need to use strings
(let! [spell "wrap"]
  (let! spell true)) ; sets wrap :D

At the moment, I decided to use option 1, because it looks a lot better.

Therefore, we have some options about how to solve this:

1. Modifying the macro to give priority to local variables if it finds them.
2. Creating a new macro with another name (e.g. set~!) that uses option 2.
3. Not using a macro for this, and just using (tset vim.g <variable> <value>).

At the moment I am using option 3, because I created my macros for idiomatic vim configuration, and using loops and the like is more scripting, and for that I don't need it to be that idiomatic.

What do you think?

[datwaft]

I added the explanation to the documentation, I will now close this issue.

[bangedorrunt]

Thank you for your explanation. I understand and totally I agree with your choice. But please add more information about this issue (in macro explanation docs?) for new users just like me who don't have an in depth knowledge at first about how macros works behind the curtain so mistake and/or confusion could be avoided 😀

[datwaft]

Yes, I will close this issue when I add that to the documentation.

Thanks!