Giter Site home page Giter Site logo

Comments (6)

davicotico avatar davicotico commented on July 22, 2024

Hi @PeterTillema, thanks for reporting that issue. I'll check it out and fix it.

from jquery-menu-editor.

lucaslm avatar lucaslm commented on July 22, 2024

Hello guys.

Wouldn't it be better to limit the event attachment to just the buttons pertaining to the editor being created? No need to dettach and reattach the same event this way.

I figured two ways to do it, and created the following branches for each:

In think I prefer the first one because the event is attached to the $main element and not the whole document, but I'm guessing the click event is attached to the document for some reason I didn't get.

from jquery-menu-editor.

davicotico avatar davicotico commented on July 22, 2024

Hi @lucaslm I appreciate your contribution.
Yes, the first one #23 is the best way.
I am going to merge it. Thanks.

from jquery-menu-editor.

davicotico avatar davicotico commented on July 22, 2024

Version 1.1.1 will be released in the next few hours.

from jquery-menu-editor.

lucaslm avatar lucaslm commented on July 22, 2024

You might want to check the other stuff I've been working on my forking of this project before releasing it.

from jquery-menu-editor.

davicotico avatar davicotico commented on July 22, 2024

@lucaslm, I really appreciate your contribution to this project. I've reviewed your other pull requests, however some of them are major changes (require a major version), so there are no plans to include them in this 1.x version. On the other hand, those pull requests that are for improvements (no structural changes), could be included progressively.

from jquery-menu-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.