Comments (8)
I solved this one but as anticipated we still get the DOMException most of the time. I think we can leave this issue open for anyone that bumps into that issue but change the title to reflect what's actually happening
from rango.
This one is interesting. I thought this type of buttons didn't work because they needed user interaction. If you open the devtools and try to click the button with rango you get Uncaught (in promise) DOMException: Clipboard write was blocked due to lack of user activation.
. The funny thing is that this only happens the second time. So it might be useful to implement what you suggest.
from rango.
It is interesting, I can also see the issue whenever I haven't interacted with a page for some time and then try to use the rango hint. So it can also fail on the first attempt.
I also don't get the error whenever I have just clicked the mouse manually (anywhere on the screen) just before issuing the command to rango, I guess this would count as recent user activation.
from rango.
philc/vimium#2521
This issue and the various issues linked off it are full of people complaining about firefox copy issues in Vimium.
from rango.
Yeah, I'll implement it but I don't think we are going to get consistent behavior.
I don't think that vimium issue has anything to do with this. We do have consistent copying/pasting to the clipboard, we do that for every command
from rango.
I tried to catch the error to warn the user when it fails by listening to window.onerror but that doesn't seem to work for DOMExceptions
from rango.
In Chrome this never works because I have to send the response back to talon before I execute the command. Since this really works anyway I don't think it's a big issue
from rango.
I've thought of a way to partially solve this by handling known cases. For example, github uses a web component called clipboard-copy
. I would need to intercept clicks to these elements and copy the value to the clipboard the same way I do for copy link
. This case seems easy enough. I suspect other cases will be more complex. If you find more of these cases post them here to see how I could handle them.
from rango.
Related Issues (20)
- "rango open read me" should take you to https://rango.click/ HOT 1
- Add setting to compute hints even when the hints are toggled off HOT 1
- rango hints break filter options on https://media.ccc.de HOT 1
- rango adds new lines to pad HOT 1
- Marks do not persist HOT 2
- Fuzzy search on link text
- `Hints to exclude` setting should be case insensitive
- Microsoft Edge Read Aloud functionality reads Rango hints HOT 1
- Question: Could Rango currently run on Electron HOT 2
- TOC has no hints HOT 1
- Add PayPal donation option HOT 1
- Add command to hide or reduce opacity of a specific hint
- nut.js changed to monorepo and is breaking npm install HOT 3
- FR: New utterance to refer to the last target
- Error: Unable to parse color HOT 3
- Mark response payload as non monitored/transient HOT 13
- Tab markers make firefox crash on startup when resuming a session with many tabs
- Toast notifications could use improved contrast HOT 1
- consider prioritizing aria labels in selectors for suggested hints
- add support for importing and exporting rule sets
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rango.