Giter Site home page Giter Site logo

Comments (7)

davidhu2000 avatar davidhu2000 commented on May 18, 2024 1

This issue is fixed in 0.2.1.

from react-spinners.

davidhu2000 avatar davidhu2000 commented on May 18, 2024

Hi @Pixelatex, can you provide more details?

For example, what version of React were you using?

What version of react-spinners were you using?

Was there any deprecation warnings in the terminal output?

The earlier 0.1.x versions were a little buggy.

I don't quite understand why devDependencies are causing issues since they should be installed in the development environment.

For example, if I start new project and run npm install react-spinners, eslint, a devDependency is not in the node_modules folder.

from react-spinners.

GiovanniFrigo avatar GiovanniFrigo commented on May 18, 2024

I had a similar issue, and for me just installing the latest prop-types module fixed the issue.

Hope this can help you, @Pixelatex

from react-spinners.

davidhu2000 avatar davidhu2000 commented on May 18, 2024

does this mean that prop-types need to be added as a dependency?

from react-spinners.

Pixelatex avatar Pixelatex commented on May 18, 2024

I think that you were relying on a now deprecated module feature which would explain why updating it breaks it. I can't recall what the issue was exactly but it was not something I could fix instantly so I had to drop your module from my project. I will try a test tomorrow and post the error if I can duplicate it again.

from react-spinners.

GiovanniFrigo avatar GiovanniFrigo commented on May 18, 2024

does this mean that prop-types need to be added as a dependency?

yes I think so.

You're using it in the code (like here) but the package is not referenced in package.json.

I think it should be a peerDependency just like react and react-dom

from react-spinners.

davidhu2000 avatar davidhu2000 commented on May 18, 2024

looks like prop-types repo recommends that the package be added to dependencies. Will fix this

from react-spinners.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.