Check the below log format: The 5th and 6th placeholder has 'value|value' passed and t

This is resolved in <a class="commit-link" data-hovercard-type="commit" data-hovercard

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

PYCEF not parsing some logs correctly about pycef HOT 4 CLOSED

davidjbianco commented on August 29, 2024

PYCEF not parsing some logs correctly

from pycef.

Comments (4)

DavidJBianco commented on August 29, 2024 1

This is resolved in 7fe1b00 and published as v1.11.

from pycef.

punkrokk commented on August 29, 2024

@anuj-agarwal want to submit a PR?

from pycef.

DavidJBianco commented on August 29, 2024

The sample log is not correctly formatted (the DeviceVersion field is missing). I don't think the answer is to change the parser, since once we know the format is invalid, we're just guessing what the remaining fields represent.

I think the better answer would be to validate that the mandatory header fields are all present, and log a warning if they're not. We already do this if the input string doesn't appear to be CEF, but the validation we use doesn't cover this case.

I'll update the code and include a test case for it.

from pycef.

punkrokk commented on August 29, 2024

Yea I agree. Cool!

from pycef.

Related Issues (7)

Recommend Projects