Giter Site home page Giter Site logo

Comments (6)

daywalker90 avatar daywalker90 commented on September 27, 2024

Yes, but i can only control what comes after They sent ERROR channel <pubkey>: You gave bad parameters: e.g. if you set the deny message to Sorry, i don't want a channel from you! it will come out as They sent ERROR channel <pubkey>: You gave bad parameters: Sorry, i don't want a channel from you!. The first part is from cln not me.

from clnrod.

daywalker90 avatar daywalker90 commented on September 27, 2024

clnrod-denymessage option defaults to an empty string that's why you don't see anything there.

from clnrod.

vincenzopalazzo avatar vincenzopalazzo commented on September 27, 2024

Yes, but i can only control what comes after They sent ERROR channel : You gave bad parameters: e.g. if you set the deny message to Sorry, i don't want a channel from you! it will come out as They sent ERROR channel : You gave bad parameters: Sorry, i don't want a channel from you!. The first part is from cln not me.

Ok I will open a patch to CLN so.

clnrod-denymessage option defaults to an empty string that's why you don't see anything there.

it is possible to set the default to another value?

from clnrod.

daywalker90 avatar daywalker90 commented on September 27, 2024

Ok I will open a patch to CLN so.

Great!

it is possible to set the default to another value?

Do you mean this: lightning-cli setconfig clnrod-denymessage "Channel rejected!". Or the actual default for every fresh installation? Both can be done. But what to choose for everyone 🤔

from clnrod.

vincenzopalazzo avatar vincenzopalazzo commented on September 27, 2024

Do you mean this: lightning-cli setconfig clnrod-denymessage "Channel rejected!". Or the actual default for every fresh installation? Both can be done. But what to choose for everyone 🤔

Any message that informs other parties that this is a custom rejection, not a protocol mismatch, would be good. If the user want a custom one will set their own reason

I would like to avoid situations where people start to claim that Lightning is broken if we don't return a custom message. For example, I am currently debugging an LND bug where I cannot open a private channel from CLN. It would be helpful to easily distinguish between different causes for these two messages.

from clnrod.

daywalker90 avatar daywalker90 commented on September 27, 2024

Fixed in v0.2.1

from clnrod.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.