Comments (4)
But why adding these additional options instead of just using the numbers that already exist? I don't see why we need
gap-xl
if we already havegap-1.5
.
Valid aspect. To give you some context on these tokens, they have been initially developed out of an older guidelines version, so both keys and values are retrieved out of this older pattern. It would be perfectly valid to use the default gap-
tokens if they fit your needs.
What do you suggest how we should proceed on this? As gap-1
, gap-2
etc. should be available to the developers already and these values could be simply taken into account only if someone sees a need in this, I could even also think about leaving them in there and documenting this quite clearly.
from base.
Thanks for the explanation, now I understand why these tokens exist. For me both would be ok, because we will use only the numbers in our application. Terms like "md" are known as breakpoints and could lead to confusion if they are also used for gaps at the same time. I guess for this reason numbers were chosen for TailwindCSS defaults. But of course you can completely customize it. Finally, a good documentation with recommendations is certainly what shows us developers the right way.
from base.
We've aligned on this again and will change it to 4px steps, like this:
"gap": {
"xs": "4px",
"sm": "8px",
"md": "12px",
"lg": "16px",
"xl": "20px",
"2xl": "24px"
},
"space": {
"xs": "4px",
"sm": "8px",
"md": "12px",
"lg": "16px",
"xl": "20px"
"2xl": "24px"
}
from base.
But why adding these additional options instead of just using the numbers that already exist?
I don't see why we need gap-xl
if we already have gap-1.5
.
from base.
Related Issues (20)
- Provide DB Screen Sans Digital Regular font references
- test(markdownlint): doesn't provide correct results
- PR merged even though that linting failed
- Not setting node version for pipelines
- SVG Icon Issues with Fill HOT 2
- Automate Icon Creation HOT 2
- DB Yellow 900: which color is correct? HOT 5
- DB fonts are not used in tailwind-specific classes HOT 1
- Icons: fill-rule="evenodd" is deleted on icon-fonts
- Tailwind Tokens: Breakpoints are inconsistent with guidelines HOT 2
- Icons update
- Icons: two transport icons with incorrect artifacts
- Illustrative icons: incorrect syntax
- Replace `pretty-quick` by `lint-staged`
- Switch from pretty-quick to lint-staged
- Using a newer Node version
- GitHub Actions: Deprecated save-state and set-output commands
- Consolidate lintings on pre-commit
- refactor: cicd install process
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from base.