Giter Site home page Giter Site logo

Affected rows is -1 about litecli HOT 8 CLOSED

dbcli avatar dbcli commented on May 19, 2024
Affected rows is -1

from litecli.

Comments (8)

delgermurun avatar delgermurun commented on May 19, 2024

@amjith How about replacing -1 with 0 :) ?

drop table foo returns -1 too. mycli returns 0 on both queries.

from litecli.

amjith avatar amjith commented on May 19, 2024

Replacing it with zero sounds fine. I just want to understand why it returns -1. Is that a latent bug in our code or is the sqlite connector behaving badly?

from litecli.

delgermurun avatar delgermurun commented on May 19, 2024

Not our code's bug. sqlite3 library returns rowcount=-1 and cursor.fetchall() returns [] empty list.

from litecli.

amjith avatar amjith commented on May 19, 2024

If the rowcount is unreliable from the sqlite3 library let's not use it at all. We'll just rely on our own counting to report that number.

from litecli.

delgermurun avatar delgermurun commented on May 19, 2024

Okay. Got it.

from litecli.

delgermurun avatar delgermurun commented on May 19, 2024

insert, delete queries return correct row count while cursor.fetchall() returns []. So we need to use rowcount for those case, I think.

from litecli.

delgermurun avatar delgermurun commented on May 19, 2024

@amjith I pushed little fix.

from litecli.

amjith avatar amjith commented on May 19, 2024

Works great!

from litecli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.