Comments (6)
The class that handles this event is Nloth.class. In the constructor:
ArrayList<AbstractRelic> relics = new ArrayList();
relics.addAll(AbstractDungeon.player.relics);
Collections.shuffle(relics, new Random(AbstractDungeon.miscRng.randomLong()));
this.choice1 = (AbstractRelic)relics.get(0);
this.choice2 = (AbstractRelic)relics.get(1);
from jorbs-spire-mod.
In the base game's EventHelper, EventHelper.getEvent()
simply instantiates and returns a new instance of Nloth event class.
from jorbs-spire-mod.
This would be a good bug for someone looking to try out making a @SpirePatch
; I think a reasonable way to implement this would be to use a SpireInsertPatch
the looks for the Collections.shuffle
call in the Nloth.class
's <ctor>
, and removes non-candidate relics from the relics
local.
I think just hard-coding Fragile Mind would be acceptable for this bug fix, but even better would be to add some sort of Annotation or marker interface (maybe NonRemovableRelic
) for Fragile Mind
to use that the patch could look for.
from jorbs-spire-mod.
Gonna work on this, seems important enough to get out of the way.
from jorbs-spire-mod.
Need to also update AbstractDungeon::getShrine
line 2239 to check the size not including Fragile Mind, otherwise, it's possible to crash with java.lang.IndexOutOfBoundsException
when instantiating the event.
from jorbs-spire-mod.
Fixed by #206
from jorbs-spire-mod.
Related Issues (20)
- Black Tendrils wording may be unintuitive/unclear HOT 1
- Attacks display incorrect damage when enemy has Coup de Grace power.
- Shadow Relic HOT 2
- Add an OnExertSubscriber
- Mind Glass's 100 damage to all doesn't work when gaining a bunch of clarities at the same time.
- Cards cannot be played via Sacrifice with 0 energy.
- Legendary starting cards are not removed from pools until act 2 or a save and load HOT 1
- Damnation Text is Missing Exhaust
- Floor count improperly increments by 1+Manifest even when not all floors are actually moved
- MirroredTechniquePower crashes the game with a type mismatch error
- Siphon change to also grant +1 Max HP
- Investment should only be available from deck of trials in Act 1
- Book of Trials should proc before Neow bonus
- Prodigal Memory should Exert when retained
- Spirit Shield rebalance HOT 1
- Blasphemer Rebalance
- Add unique card background for Deck of Trials cards. HOT 1
- If Reap and sow ends the fight the power is never applied HOT 1
- Game crashes when an on death/on victory screen shows for a non-mod character HOT 2
- Possessed has does not make Ancient One attack himself
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jorbs-spire-mod.