seeds with columns starting with underscore fail

[davidbridgwood]

seeds with columns starting with underscore fail

[Jrmyy]

👋🏻 Hello
Thanks for raising the issue, I think the error is not coming from the SQL macro but from the adapter code https://github.com/dbt-athena/dbt-athena/blob/main/dbt/adapters/athena/impl.py#L401. We are not passing the quote seed column parameter through.

[davidbridgwood]

Hey,

Ah you're right quote_seed_column doesn't currently do anything. I've had a go at implementing here but it doesn't resolve the issue i'm seeing with the columns starting with underscores.

The create external table statements want underscore prefixed columns to be surrounded in backticks but the select statement complains if thats the case.

I guess we could add a quote_character parameter to quote_seed_column and set as backtick in the DDL statements?