typeforce 1.5.1 breaks bitcoinjs-lib 1.5.8

[williamcotton]

typeforce 1.5.1 breaks bitcoinjs-lib 1.5.8

[williamcotton]

I don't know why this is happening and I don't know what version of node you were targeting with [email protected], but you NEED to push a 1.5.2 that is compatible with the older version that works with 0.12 and you NEED to release the current 1.5.1 as a 2.x.x release... it's the only way not to completely disable anyone (like me) who is on [email protected] and node 0.12.4

[williamcotton]

Also, it was a mistake to have bitcoinjs-lib have this "typeforce": "^1.0.0" dependency! Please use explicit versions in the future so as to not cause these kinds of breaking changes.

[Sjors]

I agree it would be safer if BitcoinJS limits the requirement to 1.3.* (and 1.5.* once this issue is figured out). That's already a ticket: bitcoinjs/bitcoinjs-lib#494

[mvayngrib]

+1 waiting for 1.5.2

[williamcotton]

The problem is that bitcoinjs-lib 1.5.8 is already published, so there's no going back and fixing it now...

[Sjors]

so there's no going back and fixing it now

I'm not sure if I understand; a new release of BitcoinJS (e.g. 1.5.9) could depend on version 1.3.*. Why would that not work?

[williamcotton]

All I'm saying is that [email protected] will continue to be broken along with every module that depends on [email protected], so it really needs to be fixed upstream with a working typeforce@^1.0.0... this [email protected] release with this ES6/ES2015 needs to be a [email protected] instead

[mvayngrib]

won't bitcoinjs-lib 1.5.8 start working as soon as typeforce 1.5.2 is pushed, as it'll start pulling in 1.5.2?

[williamcotton]

That is correct, and then whatever dcousens is trying to do with his [email protected] release, he should probably just bump up to [email protected], so it stops affecting [email protected]

[williamcotton]

just a tip for the future: changing the language you write a module in is probably worthy of a full version uptick in semver...

[Sjors]

BitcoinJS 2.0 is not a trivial change from 1.5.8, depending on how you use it.

[williamcotton]

(I edited the above to be more clear because it is very confusing to have these two 1.5 and 2.0 modules in discussion, sorry about that!)

[dcousens]

@williamcotton this was passing in the tests (for Node 0.10->4) because the tests use the source code directly. It appears the babel transpiler for the release did not compile the code correctly, which has surprised me greatly.

just a tip for the future: changing the language you write a module in is probably worthy of a full version uptick in semver...

It was always written in ES6.

[dcousens]

Published as 1.5.2, see 2133cc0

[dcousens]

@jprichardson, seems I need to work on my tests using the compiled code rather than the transpiler on mocha. Though, to be fair, I thought there would be no difference...

[dcousens]

Reverted use of ES6 entirely in e0241d6, too many headaches. Not worth my time for this module.
No more publish step makes me feel safer anyway.

[Sjors]

Thanks! Is there a difference between tag 1.5.5 and tag v1.5.5?

[dcousens]

@Sjors well spotted. Tag 1.5.5 removed, v1.5.5 was definitively what was published.

[dcousens]

Though, the commit hash of v1.5.5 is not flush with what is in the repository, this is because of the protected branch merge causing the tag to change commit hash on merge... hmmmm. That is a bit lame.

[jprichardson]

@jprichardson, seems I need to work on my tests using the compiled code rather than the transpiler on mocha. Though, to be fair, I thought there would be no difference...

Yeah, this is the first time I've seen Babel fail? https://github.com/dcousens/typeforce/blob/v1.5.1/package.json#L60 were you using babel5 or babel6? I can't tell from that line. If 6, and if weren't using any plugins/presets and you were using Node v4, the failure then makes sense.

[dcousens]

@jprichardson babel6 targets your node version rather than ES5?

[jprichardson]

babel6 targets your node version rather than ES5?

No. Babel6 doesn't target (or do) anything without plugins. This effectively gives the flexibility to selectively target platforms based upon what the platform supports. As a small example, if you wanted to only target Node v4 AND you wanted to use arrows, you wouldn't need the arrow transform plugin, but you would for Node v0.10. But it depends upon the code that you write and the platform that you want to target.

[jprichardson]

So,

If 6, and if weren't using any plugins/presets and you were using Node v4, the failure then makes sense.

The ES6 features that you were using were already supported by Node v4 and probably why you didn't notice any failure if you were using Babel 6 and Node v4 i.e. Babel 6 didn't do anything (assuming you didn't use any plugins/presets).

[dcousens]

Ok, it seems I've seriously underestimated how big the breaking changes in babel 6 have been. Thanks for the insight.

[dcousens]

Although, I've not had this issue in other cases...