Giter Site home page Giter Site logo

openstories's People

Contributors

audreyt avatar muan avatar robb avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

openstories's Issues

Require `feed_url` strongly.

The JSON Feed spec states:

feed_url (optional but strongly recommended, string) is the URL of the feed, and serves as the unique identifier for the feed. As with home_page_url, this should be considered required for feeds on the public web.

We should just strongly require feed_url and call it a day, this gives every feed a guaranteed unique identifier to key by.

Make `author.url` required

This should serve as a stable ID of authors across multiple feeds.

Verifying the association between this URL and the feed is tbd.

Problems loading <open-stories> and Next.js

I'm attempting to load the <open-stories> custom element with Next.js and I seem to be running into a few issues, primarily this is the error I'm getting that is preventing the element from displaying:

TypeError: Cannot set property src of #<OpenStoriesElement> which has only a getter

I'm loading the component client-side like so within a wrapper React component;

'use client'

export default function Stories() {
  return <open-stories src="/api/screenshots"></open-stories>
}

The endpoint resolves to a valid schema, when requested in the browser you get the following:

{"version":"https://jsonfeed.org/version/1.1","title":"Screenshots","_open_stories":{"version":"0.0.9"},"items":[{"id":"2605764403","content_text":"","authors":[{"name":"James","url":"https://jives.dev"}],"_open_stories":{"mime_type":"image/jpg","url":"https://steamuserimages-a.akamaihd.net/ugc/1635359675946958706/E517E16CA053E10ED3EED88E0083F157EBF860E6/","alt":""}}]}

I'm unsure if this error is directly related to Next.js or not. When I exclude the src property from the web component it loads correctly, and you can see the Shadow DOM mount. ๐Ÿค”

Any help would be super appreciated!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.