ISO's are deployed to SR instead of SR_ISO

[ddelnano]

ISO's are deployed to SR instead of SR_ISO

[AtaxyaNetwork]

What we need is a check in the GO code that determines if that name already exists in the ISO repository and then upload or skip and just reference if its there.

Already done:
4f90bf5

[tschilb252]

UPDATE: only when an ISO is downloaded from a remote URL is it placed in the SR instead of the SR_ISO.

I was able to upload a local ISO file into the SR_ISO properly when the iso_url and iso_name property are the same. If I change the iso_url to an HTTP address, it uploads the ISO to the SR and not the SR_ISO.

[AtaxyaNetwork]

Hi !

I'm currently using the provider and I had the same issue as you.
I found out, in the file common-config.go, between the line 274 and 284, config.SrName is used instead of config.SrISOName.
I changed that and i recompiled the plugin, and now my ISO is on my ISO SR.

@ddelnano: Do you want me to do a PR to change these lines ?

[tschilb252]

@AtaxyaNetwork

I worked around this by uploading my CD and just referencing the SR and the ISO itself. This prevents uploading over and over. What we need is a check in the GO code that determines if that name already exists in the ISO repository and then upload or skip and just reference if its there.

This wasn't a big issue for me since I am using the same ISO over and over and we now either make a script to upload the latest copy or manually complete that prior to deployment.

[ddelnano]

@AtaxyaNetwork that would be great. I finally have a more stable test environment for this plugin, which was a big hurdle for me quickly reviewing changes. Getting fully working CI would be great, but for now I will be able to turn around PR review more quickly.

[AtaxyaNetwork]

Done !

[ddelnano]

This will be fixed in v0.5.3, which should be available in the next hour or so!