Giter Site home page Giter Site logo

Comments (4)

ddelnano avatar ddelnano commented on August 16, 2024

@nywilken thanks for reaching out! I think this packer plugin isn't using the packer-plugins-check command. It wasn't based off the packer-plugin-scaffolding repo that you linked to.

Am I correct in thinking that this won't cause any breakage for this plugin? If that's the case, I think it would be good to eventually use the packer-sdc command for this plugin. It would be great to migrate our existing documentation to whatever is considered best practice.

from packer-plugin-xenserver.

nywilken avatar nywilken commented on August 16, 2024

Hi @ddelnano, thanks for following up. I saw the reference to the packer-plugins-check command in the project .goreleaser.yml file. So thought that it was being used.

Am I correct in thinking that this won't cause any breakage for this plugin?

If you are not using that .goreleaser.yml config for your releases than you can ignore this request and close the issue. Sorry I did not go too deep into your release process. Otherwise, I would expect your plugin release to fail once Packer 1.8.0 is released. You can also remove the check if you would like to revisit at a later time.

from packer-plugin-xenserver.

ddelnano avatar ddelnano commented on August 16, 2024

ah, that goreleaser file at the root of the repo was the one I used to publish locally before I set up GitHub actions. That file can be remove at this time and thanks for bringing this up!

from packer-plugin-xenserver.

ddelnano avatar ddelnano commented on August 16, 2024

This was completed in ac90dec

from packer-plugin-xenserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.