Default port behavior differs from Foreman

[ddollar]

Default port behavior differs from Foreman

[nhocki]

@joeyespo FWIW reading the PORT from .env is done on #45 making it -p flag, .env file, default of 5000.

[ddollar]

Looks like you're right. Would you be interested in trying to put together a pull request to correct this?

[ddollar]

Actually looks like this is covered by #45

[joeyespo]

Nice!

[joeyespo]

Ok, just tested it with the latest build.

#45 did fix the .env problem, but the order is still wrong. Here's the updated order:

• Foreman's port precedence is -p option, .env file, PORT variable, default of 5000
• Forego's port precedence is PORT variable, -p option, .env file, default of 5000

Put another way, if PORT just so happens to be in your ENV for another reason, you can't override it using .env or even -p.

[nhocki]

@joeyespo I just tested this and the order seems to be:

1. -p flag
2. PORT variable in the .env file
3. Default 5000 port.

Here's what I have:

.env

PORT=6000

Procfile

test: ruby test.rb

test.rb

puts ENV['PORT'].inspect

---

Running:

1: forego start -p 4000

forego | starting test.1 on port 4000
test.1 | "4000"

1. forego start

forego | starting test.1 on port 6000
test.1 | "6000"

1. (After removing the .env file) forego start

forego | starting test.1 on port 5000
test.1 | "5000"

---

The thing that seems to be missing in #45 is to read directly from the environment.

[ddollar]

The precedence that makes the most sense to me is:

• -p option
• PORT in .env
• PORT environment variable
• 5000

Anyone up for creating a pull request to get forego in line with this?

[nhocki]

I can add that, after @sergiobuj PR, only the PORT environment variable is missing.