ddvtech/mistlib

The official source repository for libmist.

mistlib's Issues

Completion of error handling

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

• open ⇒ Util::Procs::Start
• shutdown ⇒ Socket::Connection::close

Addition of a build system generator

I suggest to reuse a higher level build system than your current small make file so that powerful checks for software features will become easier.

• CMake
• Autotools

Infinite loop in DTSC::Stream::updateHeaders()

I've done different streaming tests on a LAN and quite often MistBuffer locks up in mistlib dtsc.cpp updateHeaders in the code block which starts on line 417:

  // delete fragments of which the beginning can no longer be reached
  while (metadata["frags"][0u]["num"].asInt() < metadata["keynum"][0u].asInt()){
    metadata["frags"].shrink(metadata["frags"].size() - 1);
    // increase the missed fragments counter
    metadata["missed_frags"] = metadata["missed_frags"].asInt() + 1;
  }

Basically, what seems to happen is that metadata["frags"].size() ends up being 0, but then when metadata["frags"][0u]["num"] is checked the size goes back to 1 (and returns 0 for the "num"), and the loop never terminates.

A hacky workaround which seems to ameliorate the problem is to add a size check in the while loop condition, like this:

  while (metadata["frags"].size() > 0 && metadata["frags"][0u]["num"].asInt() < metadata["keynum"][0u].asInt()){

However, this is probably a bit lame and someone who is more familiar with the code can probably think of a better fix :-)

make does not work on Mac OS X 10.8.2

If I run make, I get the following error:

  config.cpp:11:18: error: wait.h: No such file or directory
  config.cpp: In function ‘void Util::Daemonize()’:
  config.cpp:403: warning: ‘daemon’ is deprecated (declared at /usr/include/stdlib.h:292)
  config.cpp:403: warning: ‘daemon’ is deprecated (declared at /usr/include/stdlib.h:292)
  make[1]: *** [config.lo] Error 1
  make: *** [all-recursive] Error 1

Full log: gist

Configure doesn't notice that openssl is missing

On ubuntu 12.10, when building from git, compilation stops after a short while looking for openssl headers:

[..]
auth.cpp:2:25: fatal error: openssl/rsa.h: No such file or directory
compilation terminated.
make[1]: *** [auth.lo] Error 1
make[1]: Leaving directory `/home/lkarsten/mistlib/lib'
make: *** [all-recursive] Error 1
lkarsten@host:~/mistlib$

Fix: apt-get install libssl-dev

This should be handled by configure/automake.