Giter Site home page Giter Site logo

Comments (6)

allter avatar allter commented on May 18, 2024

The pull request is: #55

from osync.

deajan avatar deajan commented on May 18, 2024

Since your PR has been merged into 1.2-dev, I've backported the fixes to v1.1-maint branch.
Feel free to test them.

from osync.

allter avatar allter commented on May 18, 2024

Seems like deletion is now working in master. Thank you for reviewing and backporting! I have also one more fix on my other computer which is related to saving of remotely soft-deleted files. Also when I looked into code it seemed that the SOFT_DELETE=no setting was not propagated to the code executed at a remote (i.e. always soft deletion).

from osync.

deajan avatar deajan commented on May 18, 2024

Updated both branches with remote soft deletion propagation. Thanks.
Btw, master branch is pretty unstable to use right now, prefer v1.1-maint.
I've merged your PR so you could keep "property" of the commits, but osync.sh is rebuilt from dev/n_osync.sh which has most of your fixes ported, but not the extensive logging part as --verbose already deals with it.
I'm happy if you have other fixes, let me know.

from osync.

allter avatar allter commented on May 18, 2024

I looked at my other computer copy and noticed that you probably already fixed it yourself in master. It was needed to remove 1 in the following line to actually backup files in a root of osync`ed directory.
$COMMAND_SUDO mv -f "$REPLICA_DIR$files" "$REPLICA_DIR$DELETE_DIR"1

I haven't tested v1.1-maint yet.

from osync.

deajan avatar deajan commented on May 18, 2024

Yep, found that nasty typo a couple of days ago. Thanks :)

from osync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.