Comments (12)
Yes because @vtmn/react ^2.0.0
seems to require @vtmn/icons ^0.21.8
"@vtmn/icons@npm:^0.21.8":
version: 0.21.8
resolution: "@vtmn/icons@npm:0.21.8"
checksum: eb6b8a05630214af831d65d660e319d89ab9cfad457e96f0feea54d4b7a86cf098327e2faf9d1bfcc03c5877fec3ddb59c6820f283e026e0781d229e79c8f152
languageName: node
linkType: hard
"@vtmn/icons@npm:^1.1.0":
version: 1.1.0
resolution: "@vtmn/icons@npm:1.1.0"
checksum: fc7adfe1d9f53fedc6bfb06e2f0494d72405639b46eacc218dc38fed444e51ca2342054e51378d545e641dd6545ff9635f81c0fc04fc8ba2d6f7568ca55f92fe
languageName: node
linkType: hard
"@vtmn/react@npm:^2.0.0":
version: 2.0.0
resolution: "@vtmn/react@npm:2.0.0"
dependencies:
"@vtmn/icons": ^0.21.8
peerDependencies:
react: ">=16.8.0"
react-dom: ">=16.8.0"
checksum: bba5ebbe83f2acc25a7ff48509d72adc1bd86c07d1df4e79f21ea07feb6a3a453f7677bde0ec90da5c732308a7ff2c588a668f7950f98105f02e8310a54d9e3d
languageName: node
linkType: hard
from vitamin-web.
Good call, one reference of the old package wasn't updated on the package lock json. I had to remove it by hand and delete the node modules to remove all references.
from vitamin-web.
I think I found the problem, that's because the "accessibility-fill" icon is a new icon and was not available in your version @vtmn/icons@npm:^0.21.8
.
This PR should fix the problem: #1415
Sorry I have two meetings, can you please review this PR? I will come back to you after.
from vitamin-web.
Yep, I have the same problem as @Jerome1337. Every time I do a npm i, I have to remove the dependencies:
"@vtmn/icons": ^0.21.8 in the lock and delete the node modules.
Seems like there's still a reference of that old version somewhere.
from vitamin-web.
It's done, thank you :) !
from vitamin-web.
Hello @JulienGaudet
Thanks for your message :) I can't reproduce this problem unfortunately though. In your message there seems to be a mismatch between the versions of @vtmn/icons
: @vtmn/react ^1.1.0
uses @vtmn/icons ^1.1.0
, but you may still have an old version of @vtmn/icons
. Did you eventually try to bump it in your package.json?
from vitamin-web.
Thank you for your quick response, yes I try to bump all versions at the same time. I will try again right now
from vitamin-web.
Hi @thibault-mahe, it seems to have a version mismatch since 2.0.0
has been released.
@vtmn/icons
doesn't have a 2.0.0
version then when we use @vtmn/react ^2.0.0
we get the same error as mentioned above. But in fact @vtmn/react ^1.1.0
+ @vtmn/icons ^1.1.0
works.
Is there a release tag missing on @vtmn/icons
?
from vitamin-web.
Hi @Jerome1337,
@vtmn/icons
doesn't have version 2.0.0
, that's normal, package versioning is independent (and there wasn't any breaking change for icons).
Can you please send us your error with log trace?
For your information, the bump to [email protected]
only did this: 25a7c16 (Skeleton component, nothing related to icons). I also made this PR to align our internal dependencies to the latest available: #1415.
from vitamin-web.
Hi @lauthieb,
Here is the stack trace when trying to pass a custom props that has the @vtmn/icons VitamixId type
to iconLeft
iconRight
iconAlone
of the VtmnButton
Type 'import("/Users/JEROME/Documents/Projects/oneSquare/front/node_modules/@vtmn/icons/dist/vitamix/font/vitamix").VitamixId | undefined' is not assignable to type 'import("/Users/JEROME/Documents/Projects/oneSquare/front/node_modules/@vtmn/react/node_modules/@vtmn/icons/dist/vitamix/font/vitamix").VitamixId | undefined'.
Type '"accessibility-fill"' is not assignable to type 'VitamixId | undefined'.
But when downgrading @vtmn/react
to v1.1.0
every is working
from vitamin-web.
Thanks @Jerome1337 do you have two different versions of @vtmn/icons
in your lock file (package-lock.json or yarn.lock)?
from vitamin-web.
@JulienGaudet, yes and that's why this PR #1415 should solve your problem.
Can you also please review it? We will merge it this morning with @thibault-mahe
Btw, thank you @Jerome1337 for your approval.
from vitamin-web.
Related Issues (20)
- feat(@vtmn/svelte, @vtmn/react, @vtmn/vue): make it possible to pass height to `VtmnSkeleton` component
- bug(@vtmn/css): the arrow is offset when there is no label HOT 1
- feat(@vtmn/svelte, @vtmn/vue, @vtmn/react): possibility to add a `VtmnBadge` on the `VtmnNavbarLink` HOT 1
- bug(@vtmn/icons): icons are displayed outside of viewBox HOT 2
- bug(@vtmn/react): missing icons HOT 1
- bug(@vtmn/svelte): `VtmnNavbarLink` is not SSR compliant HOT 1
- docs: typeface is now deprecated HOT 3
- bug: Allow label in Input to be a component rather than a string
- bug: the thumb of the `Toggle` component doesn't have the right color in dark mode
- bug(`@vtmn/css`): The placeholder a cropped on the VtmnSearch
- feat(`@vtmn/svelte`, `@vtmn/vue`, `@vtmn/react`): add summary as slot for `VtmnAccordion`
- bug(@vtmn/css): `VtmnRating` stars out of the box with many reviews. HOT 3
- feat: enhancement `VtmnCard` variant for SSR HOT 2
- feat: improve the `VtmnIcon` in order to used SVG HOT 9
- bug(@vtmn/react): VtmnQuantity "-" and "+" buttons should not validate form instantly HOT 1
- feat(@vtmn/css): enhancement `VtmnSelect` make the props label optional HOT 1
- bug(@vtmn/react): Having warnings "fail to parse source map" using React / TSX HOT 2
- bug: wrong behaviour on the `VtmnChip`
- bug(@vtmn/svelte): linear progressBar not displayed correctly on storybook HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vitamin-web.