Giter Site home page Giter Site logo

Comments (3)

alecslupu avatar alecslupu commented on June 2, 2024

@cyberschnaps Help me a bit with more context, I have tried what you stated, and i could not find anything wrong.

The code responsible for displaying the 12 columns :

<div class="grid grid-cols-12 gap-4">
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
      <div class="bg-primary/10 text-center h-10"></div>
  </div>

Removing 9 columns rows like: <div class="bg-primary/10 text-center h-10"></div> will result in having the below picture.

image

from decidim.

cyberschnaps avatar cyberschnaps commented on June 2, 2024

@alecslupu thank you for your reply :) Sorry, my request wasn't clear:

Context: We are building a design system on Figma to reflect what is available in 0.28 on try.decidim.org. When trying to apply the logic published on try.decidim.org/design it doesn't fit the front-end's reality when verifying with the inspector.

Problem: The design guide states the Layout is based on 12 columns on Desktop, but in reality it seems it is based on 3 columns with a max-width, and responsive gutters and margins, not 16px & 48px.

Am I missing something? Where can one see the 12 columns layout used with the inspector obeying these rules?

Captures

  • Figma with 12 columns layout (does not reflect try.decidim.org)
  • Inspector on homepage of try.decidim.org (does not reflect the design guide)

Figma
Inspector

from decidim.

cyberschnaps avatar cyberschnaps commented on June 2, 2024

Thank you for moving this to the maintainer's backlog @andreslucena.

...In the meanwhile (which might take a while given the issue), https://try.decidim.org/design/foundations/layout should reflect the reality. Will it be changed accordingly so that designers can actually understand how the front-end is built?

If this is not the case, will you remove the Desktop, Tablet and Mobile sections of the layout page so that it does not add any confusion?

Thank you :)

from decidim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.