Giter Site home page Giter Site logo

Comments (5)

peterpeterparker avatar peterpeterparker commented on May 24, 2024

Hi Lex,

Not sure I get what you mean. I tried https://www.robowrite.app/output but did not find the inline editor, therefore I am a bit confused about both the issue and the expectation.

Can you provide a screenshots / mockups or something?

That would help me gets the context, thx in adance.

from deckdeckgo.

Lxstr avatar Lxstr commented on May 24, 2024

I think I was hoping to have the sticky editor 'push up' (or down) the editable view rather than overlay itself. When you select text near the toolbar it often covers the text. Does that make sense?

1
Screen Shot 2021-07-29 at 1 37 22 pm

from deckdeckgo.

peterpeterparker avatar peterpeterparker commented on May 24, 2024

Thank you for the screenshots.

  1. About "sticky"

The sticky-desktop is indeed the property to be used to make the editor not overlay but, appear at the bottom. It can be displayed at the top but, only on iOS.

Therefore if you want it to be sticky and appear at the top, it would need an enhancement in the code.

Do I understand correctly that part?

Note: the inline editor is mostly though to work as an overlay editor and to be sticky on mobile devices. If you want something sticky all the time maybe other wysiwyg editor as https://www.tiny.cloud/ are more suited for your use case?

  1. About "covers the text"

Regarding your statement "text near the toolbar it often covers the text", did you notice this in DeckDeckGo, our editor for presetations? Can you provide another screenshot example?

Not sure it can be solved in that form though, it's really trick to have both a floating wysiwyg editor in addition to the native wysiwyg options displayed by the os in addition to the keyboard/window size changing or not.

from deckdeckgo.

Lxstr avatar Lxstr commented on May 24, 2024

Hi David,

Thanks for the clarification. I'm having more of a play around with it the last few hours and I'm still getting to understanding it.

Definitely don't see any need for a sticky desktop editor. I was confusing there because I was testing on my browser, hence the screenshot of the sticky at the bottom and selecting sticky-desktop.

Haven't actually implemented any of the other WYSIWYGs (only researched them) but I quite like DDG editor because it only shows when text is selected.

Also, totally hear you regarding changing window sizing.

I think that way it works in ios DDG is great because it just covers the existing Nav bar, but currently it goes under my nav bar so I'll look into why that is.

I have a few other things floating around in my head as I've been playing with the code and I'll do a little more next week.

For example something different but related :

  • Flex-wrap for narrow screens where the toolbar doesn't fit which I've coded but it because it goes two lines down would be more likely to cover high up text that a user has selected when in sticky mode.

Screen Shot 2021-07-29 at 3 16 36 pm

from deckdeckgo.

peterpeterparker avatar peterpeterparker commented on May 24, 2024

Cool! If you play with the code let me know if you find any ways to simplify its code base. Kind of think it is over-complicated for what it does 🤷‍♂️. Really took me quite some time to implement, inputs really appreciated.

Regarding "flex-wrap", that would be a solution. Another one would maybe be to make the options smaller and therefore use less space?

If have to say we do not have that issue IRL in our editor because we reduced the amount of options. Less options, less space, problem solved 🤣.

I don't have currently much time to implement anything if you would discover any issues or else but for sure, really happy to hear all your suggestions and questions. Keep me posted!

from deckdeckgo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.