Comments (7)
Designs for an alternative view
Changed tabs to dropdowns+notice that we decided to be back to cyan color for active tab underlining (everywhere)
Preview: https://xd.adobe.com/view/d3332251-ae10-41e4-6bf4-1f3d90c11d84-a502/
Specs: https://xd.adobe.com/spec/2780360d-2ca6-4aeb-7fc8-8ad4e1b94be7-51b1/
from pi-ui.
Yes, that sounds like the way to go. Just have in mind that you can pass custom components for the dropdown trigger (or title as you said).
If you find that this approach is not doable or that the tabs should have its own custom mode instead of mixing with the dropdown, just let me know and we can switch approaches. Just make sure we can achieve the desired output and it's easy to "toggle" the tabs to have it modified.
For example, ideally what I have in mind is something like this:
<Tabs dropdownMode={true/false}>
<Tab> tab 1 </Tab>
<Tab> tab 2 </Tab>
</Tabs>
Basically through the dropdownMode
prop we should be able to alternate between the modes without any hassle.
from pi-ui.
@fernandoabolafio will try achieve what we described above and will let you know, thanks a lot for your replies
from pi-ui.
So to achieve the result shown in the design we will need to adjust 'drowdownitem' to accept count
prop as well ? or should it be in the direction of using the dropdown
with tabs
as shown here (dropdown with tabs example)
from pi-ui.
@amassarwi to me it makes more sense to achieve by using the second approach "using the dropdown with tabs". Because we can do pretty much what was already done in the example you mentioned and replace the dropdown trigger by the appropriate component from the design specs. What do you think?
from pi-ui.
@fernandoabolafio, totally agree, we will need disable active tab indicator and update dropdown title to be the active tab label on tabs switch, right ?
from pi-ui.
closed on #131
from pi-ui.
Related Issues (20)
- CopyableText: change color and font weight HOT 2
- Link: add underline on hover HOT 1
- Tabs: implement new design specs
- Tooltip: implement new design specs HOT 1
- High contrast greyscale themes
- Button Icon optional Tooltip HOT 1
- SyntaxError on Button docs
- Default Theming
- Layout Improvements
- [DatePicker] Make value and onChange props required
- [Icon] list all possible icon types on propTypes
- [Components] Add style to the propTypes of components that accept one
- [Icon] Standardize Icons Sizes
- [BoxTextInput] Add Info icon tooltip
- [Datepicker] Make datepicker arrow responsive
- [Dropdown] Allow dropdown header customization
- [Modal] Close Button improvements
- [Tooltip] UI Improvements
- Rename pi-ui
- Icons: Add `ledger` icon. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pi-ui.