CFBundleName should be changed

[deemru]

CFBundleName should be changed

[deemru]

We are not in depth of mac features, why it "should be"? Are there any cons?

[core-code]

well.

CFBundleName is the name of the app. if you leave it at 'Chromium' your app is indistuingishable from upstream original Chromium. you've already re-named it in the file-system so it makes sense to also adjust the bundle name.

other Chromium forks like Chedot, Epic, ipDTL, Iron RocketNav and Superbird have also adjusted their CFBundleName.

[deemru]

So technically (for an user) there are no real cons and renaming is needed just to make sense and be distinguishable in some mac internals.

We try to update this value in a next release. Thanks.

[core-code]

awesome thanks

[deemru]

af6e138#diff-1442bb1852f322463b7846df55f396f109ac43811a75b761e426865fe0c1327aR72

done?

[core-code]

you are changing the CFBundleIdentifier instead of the CFBundleName. that fullfills the objective (make it distuingishable) but i cannot guarantee that there are no negative side effects in this case.

[deemru]

This is it? bfdcc37#diff-1442bb1852f322463b7846df55f396f109ac43811a75b761e426865fe0c1327aR80

[core-code]

looks good thanks. will give a definitive confirmation when the next build is out

[deemru]

Next build: https://github.com/deemru/chromium-gost/releases/download/90.0.4430.72/chromium-gost-90.0.4430.72-macos-amd64.tar.bz2

[core-code]

thanks, i had a look. i can confirm that the CFBundleName has been changed, which is what the bug report was about ("Chromium" => "Chromium-Gost")

i can also confirm that the build has a changed CFBundleIdentifier ("org.chromium.Chromium" => "ru.cryptopro.chromium-gost")