Configuring the logger overrides what is configured in logging.config

[deepbrook]

Configuring the logger overrides what is configured in logging.config

[theladyjaye]

Actually a backwards compatible solution that might be more appealing:

set this to log_level=None in the init kwargs
https://github.com/nlsdfnbch/Pysher/blob/master/pysher/connection.py#L10

if log_level is not None:
    if log_level == logging.DEBUG:
            websocket.enableTrace(True)
        self.logger.setLevel(log_level)

or get the logger to see if it's been configured already to see if it's level is DEBUG then only do the websocket.enableTrace after that test..

[deepbrook]

Hey @aventurella , thanks for reaching out!

So if I understand you correctly, the issue you're pointing out is that currently we need to explicitly pass the log_level kwarg to set it to anything other than logging.INFO, despite having set the log level previously in a global configuration, correct ?

[theladyjaye]

Yes, that’s the issue.

[theladyjaye]

So killing that kwarg, or setting it to None and only touch the logger if it’s not None would do the trick

[deepbrook]

Thanks for contributing! I'll close this once I've implemented this.