Comments (3)
Hi, what is the bug here exactly? The information is in the readme:
Some target languages also include the regional variant according to ISO 3166-1, for example 'en-US', or 'pt-BR'. The source language also accepts null, to enable auto-detection of the source language.
and this is not a recent change, we haven't accepted en
as a target language for years.
You can use Translator::getSourceLanguages()
and Translator::getTargetLanguages()
to query the currently accepted languages from the API, or use the constants we define in the library, note the comments for english:
/** English language code, may only be used as a source language. */
public const ENGLISH = 'en';
/** British English language code, may only be used as a target language. */
public const ENGLISH_BRITISH = 'en-GB';
/** American English language code, may only be used as a target language. */
public const ENGLISH_AMERICAN = 'en-US';
from deepl-php.
@JanEbbing that's weird. Our plugin was working fine when using just en as a target language code and it just broke in the last few weeks with that deprecation notice. The documentation states that you have to pass a locale code in order for the glossary to work and unless we change our Moodle install to use regional variants we'll have to hardcode locales into the plugin to make it work with DeepL now.
On the readme it shows $translationResult = $translator->translateText('Hello, world!', 'en', 'fr');
but my understanding is that I now have to use en-US or en-GB, etc and that I cannot use en. Am I misunderstanding something here?
from deepl-php.
Hi @kalebheitzman - not sure why it broke, but we did not change anything in this regard. DeepL differentiates between a sourceLanguage
(language the text is in, can be null in order to be inferred) and a targetLanguage
(language to translate the text into) - the targetLanguage
needs the regional variant to be specified, else it will throw an error (unfortunately only once you actually call the function, as we want users of older library versions to be able to use languages released after the library version).
In the example
$translationResult = $translator->translateText('Hello, world!', 'en', 'fr');
we call translate
with a sourceLanguage
of 'en'
and a targetLanguage
of 'fr'
, which is fine. On the other hand,
$translationResult = $translator->translateText('Bonjour, le monde!', 'fr', 'en');
would throw an error, you would need to write something like
$translationResult = $translator->translateText('Bonjour, le monde!', 'fr', 'en-GB');
from deepl-php.
Related Issues (20)
- Encode/decode the results for italian and other languages? HOT 7
- FEATURE REQUEST: Add support for changing httpClient HOT 3
- Problems with POST request with getUsage (400 status code - bad request) HOT 3
- Feature request: Make it possible to retrieve billing period for usage HOT 1
- Edit entry in glossary HOT 1
- Autoloading not working HOT 3
- Glossary Japanese symbols issue? HOT 4
- BUG: Class Http\Discovery\Psr17FactoryDiscovery not found error HOT 2
- Version 1.5.0 should be considered a breaking change? HOT 6
- Call to undefined function DeepL\curl_version() in deeplcom\deepl-php\src\Translator.php:738 HOT 3
- instaling libreries without composer HOT 9
- Usage API may not return limit HOT 4
- mb_str_split() not supported in PHP 7.3 HOT 2
- [Security] Actions due to/Information around CVE-2023-38545 HOT 1
- Does DeepL support translating rich text contents? HOT 1
- ErrorMessage -> too many errors HOT 1
- Progress bar for DeepL PHP API HOT 1
- 413 Request Entity Too Large HOT 2
- Missing in the PHP library the parameter "output_format" ("docx" for translating a PDF file into a Word document)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deepl-php.