Fix test suite when reading image file

[deeplook]

Fix test suite when reading image file

[claudep]

I can't open that image (cloudqllo.jpg) in my image viewers (Gimp cannot open it either). So I'm rather surprised the test passed before! We might have to find a way to know if the image is valid before rendering.

[deeplook]

Same here, and this image is not even referenced explicitly in any of the SVG files in W3C_SVG_12_TinyTestSuite/svg. So maybe it's used in some kind of loop...

[claudep]

I'm working on convertImage now, several things need updating.

[claudep]

With the above commits, the tests run fine on Python 2, however on Python 3, I'm confronted with https://bitbucket.org/rptlab/reportlab/issues/98/

[deeplook]

Funny error. Especially since the reportlab.graphics.renderbase.Renderer class has neither a drawImage method nor a superclass...

[deeplook]

@claudep I suggest you send a message on the RL mailing list, which is what they observe more thoroughly than some issue tracker. And tell Robin this is kind of a late X-mas gift from me. ;-)

[claudep]

I don't know if this is really a gift or not for RL, as I don't know the capabilities of their closed-source PLUS version.

[claudep]

ReportLab 3.3.26 solves this issue. Now should we still add some workaround code with Python 3/ReportLab < 3.3.26, considering that such combinations might be used in the next two years at least? (next Debian will have 3.3.0, as has Ubuntu 16.04).

[claudep]

However, I'm not sure we can do anything, as we cannot know whether the drawing we are building will be used to render an image or a PDF or anything else.

[deeplook]

Assuming reportlab 3.3.26 can be installed flawlessly, I'd opt for adding a note to the testsuite's README and the respective code line where the PNGs are created to use this with reportlab 3.3.36, rather than pin this version in the requirements, since I believe typical reportlab users are not jumping on new versions automatically. Does that make sense?

[claudep]

+1 to not require this version and to a note in the README.
I don't think converting to PNG is a much used ability of svglib, considering ImageMagick does it too.

[deeplook]

Done in d122b5b.