Giter Site home page Giter Site logo

Comments (6)

perdrix52 avatar perdrix52 commented on July 16, 2024 1

I definitely could make this change and it would be moderately simple to do (though it has impact way beyond the code I pointed you to). It would be part of the next release if done. Would I be correct to think that you still want the code to scale 12 and 14 bit data to 16 bit?

Darn - this would mean even MORE translation work to be done.

David

from dss.

perdrix52 avatar perdrix52 commented on July 16, 2024

Hi Ivo, the current code doesn't use DcRaw at all, and we do our own WB processing. However I while I am prepared to consider allowing an option to bypass white balance processing, I don't understand why it's a problem. The code we use is very simple;

See: RawUtils.cpp lines 1093 to 1153

https://github.com/deepskystacker/DSS/blob/master/DeepSkyStacker/RAWUtils.cpp

So what could that be doing that messes up your code?
David

from dss.

IvoJager avatar IvoJager commented on July 16, 2024

Thanks for the lighting quick response David - it is much appreciated!
Looking at the code, pre_mul[0], pre_mul[1], pre_mul[2], pre_mul[3] should all be forced to 1.0 for white balancing to not take place. Currently, it appears these are set by a copy from either C.cam_mul or C.pre_mul. I'm not quite sure where these, in turn, are set.

To recap, the problem occurs when the values in pre_mul are anything but 1.0 (as would be accomplished by the -r 1 1 1 1 parameter).
This causes the signal to be multiplied by an amount that cannot be known by the program used to post-process the stack. Because these multipliers cannot be known, it cannot be known by the program post-processing the stack how the signal and its noise component were impacted in each channel. This in turn makes the correct weights for creating a synthetic luminance dataset unknown. This in turn yields to a noisier synthetic luminance frame than needed, leading in turn to a poorer image and less effective results from algorithms such as deconvolution.

In addition, when stacking an image shot with the increasingly popular duoband filters for DSLRs, white balancing becomes rather meaningless, and the impact on synthetic luminance creation even more detrimental.

Does this make sense?

from dss.

IvoJager avatar IvoJager commented on July 16, 2024

Sorry about the translation work, but you would make a lot of people very, very happy indeed! :)
Please keep the proper global scaling in place, as-is. It's just the disparity in color channel scaling (aka white balancing) we're trying to eliminate for people with our use cases. Say the word and I'll bring the good news to the StarTools forums!

from dss.

perdrix52 avatar perdrix52 commented on July 16, 2024

This will be added to to the next release (4.2.3).

David

from dss.

IvoJager avatar IvoJager commented on July 16, 2024

That's fantastic news David - thank you very much!

from dss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.