Comments (6)
I definitely could make this change and it would be moderately simple to do (though it has impact way beyond the code I pointed you to). It would be part of the next release if done. Would I be correct to think that you still want the code to scale 12 and 14 bit data to 16 bit?
Darn - this would mean even MORE translation work to be done.
David
from dss.
Hi Ivo, the current code doesn't use DcRaw at all, and we do our own WB processing. However I while I am prepared to consider allowing an option to bypass white balance processing, I don't understand why it's a problem. The code we use is very simple;
See: RawUtils.cpp lines 1093 to 1153
https://github.com/deepskystacker/DSS/blob/master/DeepSkyStacker/RAWUtils.cpp
So what could that be doing that messes up your code?
David
from dss.
Thanks for the lighting quick response David - it is much appreciated!
Looking at the code, pre_mul[0], pre_mul[1], pre_mul[2], pre_mul[3] should all be forced to 1.0 for white balancing to not take place. Currently, it appears these are set by a copy from either C.cam_mul or C.pre_mul. I'm not quite sure where these, in turn, are set.
To recap, the problem occurs when the values in pre_mul are anything but 1.0 (as would be accomplished by the -r 1 1 1 1 parameter).
This causes the signal to be multiplied by an amount that cannot be known by the program used to post-process the stack. Because these multipliers cannot be known, it cannot be known by the program post-processing the stack how the signal and its noise component were impacted in each channel. This in turn makes the correct weights for creating a synthetic luminance dataset unknown. This in turn yields to a noisier synthetic luminance frame than needed, leading in turn to a poorer image and less effective results from algorithms such as deconvolution.
In addition, when stacking an image shot with the increasingly popular duoband filters for DSLRs, white balancing becomes rather meaningless, and the impact on synthetic luminance creation even more detrimental.
Does this make sense?
from dss.
Sorry about the translation work, but you would make a lot of people very, very happy indeed! :)
Please keep the proper global scaling in place, as-is. It's just the disparity in color channel scaling (aka white balancing) we're trying to eliminate for people with our use cases. Say the word and I'll bring the good news to the StarTools forums!
from dss.
This will be added to to the next release (4.2.3).
David
from dss.
That's fantastic news David - thank you very much!
from dss.
Related Issues (20)
- Problem with image count display when removing images from the list.
- Enabling Super pixel mode crops image to upper left 1/4 HOT 1
- Picture list column does not show up! HOT 4
- Translate DeepSkyStacker in another language HOT 3
- Can't install DSS HOT 11
- Can't open again the "Explorer" bar (left panel) HOT 2
- Cross platform proposition (linux/Mac) HOT 5
- Crash in edit comet mode
- FITS Header OBSERVER truncated HOT 2
- FITS Header OBJECT not in output HOT 1
- FITS header DATE-OBS missing in output file HOT 1
- FITS header FOCALLEN missing in output file HOT 1
- FITS header XPICSZ, YPICSZ missing in output file HOT 1
- FITS header field EQUINOX missing in results file HOT 1
- DSS 5.1.4 wont launch in Windows 11 HOT 2
- DSS5.1.5 - Error Message "The System canno find the path specified" HOT 1
- DeepSkyStacker broken on non latenic letter user HOT 5
- Incorrect temp directory, 5.1.5, Windows 11 HOT 6
- Error when attempting to select a Comet in a picture HOT 3
- To do May 2024 HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dss.