Publisher fails to parse HEALTHCHECK_INITIAL_DELAY if the value contains `\r`

[NickAb]

Publisher fails to parse HEALTHCHECK_INITIAL_DELAY if the value contains `\r`

[bacongobbler]

@NickAb since we want to preserve whitespace when someone uses config:set, I think the right way to tackle this would be in the CLI.

If you're up for it, one way we could handle this is by converting all /r/n and /r control characters into /n.

What version are you running?

[NickAb]

I am using 1.13.2 on Windows 8.1 x64.

Maybe CLI should show warning when trying to config:push file with Windows line endings and have an option to auto-convert line endings, how does it sound?

Although handling that in CLI might be a good idea, I still think that Publisher should be able to parse HEALTHCHECK_INITIAL_DELAY even if it contains \r, because Publisher expects the value to be a number and it can ignore any white-space as it is clear that user intended to set a number value for this variable.

[Joshua-Anderson]

@NickAb Since Deis V1 is in LTS mode, and the CLI on windows is experimental, this is unlikely to get a fix for Deis V1. However, patches are always welcome!

I believe this is an problem with Deis Workflow (V2) as well. Windows is officially supported in Workflow, so I'll look into getting a fix for it there. This might also be fixed by switching to .env parsing library, like what was suggested in #4512 for supporting multiline environmental variables.

[bacongobbler]

closing as irrelevant for v2.