Comments (1)
After further examination of v1.x router docs and code, I apparently misinterpretted enforceWhitelist
as a router-wide toggle for enforcement of app-specific whitelists. That's partially accurate, but reality is more nuanced. enforceWhitelist
requires a whitelist to be defined for each and every app. Apps with no whitelist defined do not permit any access. Contrast this to how this is implemented in v2 and it's strictly a feature toggle.
The use cases that come to mind most easily for the use of whitelists is for non-production (e.g. staging) applications or internal applications-- or entire clusters of non-production or internal applications. I'd propose we can do a bit better than v1.x did in addressing these.
With v1.x., and enforceWhitelist=true
, any new app was initially inaccessible to all unless someone incurred the time and effort to curate its whitelist. Managing these lists across a large number of apps in a large Deis cluster could be time consuming and vexing.
I would propose that enforceWhitelist=true
should work in v2 just as it did in v1.x, but that it should also be possible to establish a router-wide, default whitelist that can be either extended or overridden on an app by app basis. This would allow, then, all new internal or non-production applications to inherit a sensible whitelist from the cluster without creating an admin nightmare for ops.
from router.
Related Issues (20)
- need annotation for nginx proxy_buffer_size HOT 5
- When using proxy protocol, X-Forwarded-For header should be set to $proxy_protocol_addr HOT 4
- TCP support for Deis applications HOT 22
- HPKP Public-Key-Pins Header HOT 7
- Per domain real_ip_header HOT 1
- When <sub>.example.com domain is added to app on example.com cluster, ssl configuration is missing HOT 1
- Clickjacking prevention header? X-Frame-Options HOT 2
- Random 502 bad gateway HOT 10
- There's no point in having Travis build HOT 5
- Proxy Protocol Port not used to determine Access Scheme HOT 7
- Trouble setting service_annotations via chart values file HOT 4
- Proposal: Add aws load balancer timeout override to service template HOT 2
- Router makes zombies permanently HOT 9
- Claiming a reserved name for the router HOT 3
- Documentation still has some references to Helm Classic HOT 3
- GKE Failed: Create Address error` HOT 2
- Custom "Site Maintenance" page HOT 3
- Deis router picks up non-Deis traffic HOT 15
- Config builder silently fails with missing annotations HOT 2
- Support non-HTTP, streaming apps HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from router.