Giter Site home page Giter Site logo

Comments (1)

krancour avatar krancour commented on August 22, 2024

After further examination of v1.x router docs and code, I apparently misinterpretted enforceWhitelist as a router-wide toggle for enforcement of app-specific whitelists. That's partially accurate, but reality is more nuanced. enforceWhitelist requires a whitelist to be defined for each and every app. Apps with no whitelist defined do not permit any access. Contrast this to how this is implemented in v2 and it's strictly a feature toggle.

The use cases that come to mind most easily for the use of whitelists is for non-production (e.g. staging) applications or internal applications-- or entire clusters of non-production or internal applications. I'd propose we can do a bit better than v1.x did in addressing these.

With v1.x., and enforceWhitelist=true, any new app was initially inaccessible to all unless someone incurred the time and effort to curate its whitelist. Managing these lists across a large number of apps in a large Deis cluster could be time consuming and vexing.

I would propose that enforceWhitelist=true should work in v2 just as it did in v1.x, but that it should also be possible to establish a router-wide, default whitelist that can be either extended or overridden on an app by app basis. This would allow, then, all new internal or non-production applications to inherit a sensible whitelist from the cluster without creating an admin nightmare for ops.

from router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.