Comments (3)
Negating BUILD_EXCLUSIVE
that means we want a BUILD_REQUIRES
right?
Overall I like the idea, but I'm a little concerned about:
- conflicting configuration - doable but needs documentation and tests, which can raise the complexity
- forward and backward compatibility - say I create a new dkms module that uses the new token and some users try it against older dkms
Latter is a bit moot point, since we don't do much of that atm. The former seems far more relevant IMHO.
from dkms.
I would see it more as BUILD_EXCLUDE
, but that's visually very similar ..
I don't see a potential for conflicting configuration. All BUILD_EXCLUSIVE_*
settings define some contraints, and if a kernel does not match any one of them it is thrown out.
New directives will be ignored by older dkms, we just shouldn't change the meaning of the previously existing ones ...
The modules will simply fail to build with the older dkms since it was impossible to express the constraint to exclude that kernel at that time.
from dkms.
I may or may not have misread "exclusive" as "exclude" in the first place 😛
Speaking of conflicting configuration, let's consider BUILD_EXCLUSIVE=5.1
and BUILD_EXCLUDE=5.*
. This should result in 0 modules handled, correct? It is somewhat of a nonsensical config, so I'm wondering if that should be success, skip or failure? Do we want to inform the user about the potential typo/miss-config?
from dkms.
Related Issues (20)
- Kernel match for BUILT_MODULE_NAME HOT 9
- Introduce a `build $module for all kernels` functionality HOT 1
- Reintroduce support for `dkms add/build/install m/v --all` HOT 1
- A typo in the readme file
- Ubuntu 22.04 VM broke HOT 6
- marking built/installed modules as rebuild-needed
- parameter validation
- 3.0.13 release isn't tagged as latest on GitHub HOT 1
- OBSOLETE_BY does not prevent building HOT 1
- Retrospective from the recent XZ vuln HOT 1
- DOS-style line endings in dkms.conf break dkms in unpredictable ways HOT 1
- Stop handling dkms.conf as a bash/shell script HOT 8
- Failing to compile nvidia-open-dkms while using a ThinLTO/Clang kernel HOT 3
- Leftover files after zfs build HOT 2
- Keep the Module.symvers file along with the *.ko HOT 2
- In the loop, why is it a read-only variable? HOT 4
- nvidia-open-dkms: Strip assertion failed (ThinLTO compiled kernel) - Module succesfully compiled but can not boot HOT 2
- automate running "`sudo mokutil --import /var/lib/dkms/mok.pub`" HOT 6
- Ship `kernel-install` snippet to `/usr/` instead of `/etc/` HOT 2
- Supporting non-DKMS modules using a vendors external tools
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dkms.