Giter Site home page Giter Site logo

Comments (3)

adbenitez avatar adbenitez commented on August 16, 2024

UI-wise, no new options are needed. as a minimum, make “Settings / Notifications / On/Off” a per-profile switch.

it is not that easy, we have the notifications permission that user may not grant and we would still need to display the state of the global app notifications
EDIT: maybe show disabled for all even if enabled, when permission is not granted and and on enabling request permission or go to system settings to change the permission, I guess

not sure this aligns with "maintenance" but well :)

from deltachat-android.

r10s avatar r10s commented on August 16, 2024

afaik, the "Settings / Notifications / On/Off" switch was never meant to reflect the system setting, let alone that it can change it.

if the user has disabled notification permission in the system, the whole settings dialog is not reachable but a warning is shown instead. this is fine and can stay as is. "Settings / Notifications / On/Off" anyways cannot be altered or viewed.

so, my idea is really only to only replace Prefs.isNotificationsEnabled() by eg. dcContext.getConfig("notifications_enabled") and let the setting-switch change that setting.

from deltachat-android.

adbenitez avatar adbenitez commented on August 16, 2024

then first we need a core issue for this

from deltachat-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.