Comments (4)
i think, the key timestamp_format_m_desktop
is very questionable at all.
translators do not really know what to do with it, i just did a grep, it is seems also wrong in at least one other language. - ukranian has "MMMM" (may this exists, idk), khmer is ែ ថ្ងៃ, which seems wrong.
all others are "MMM D" or "D MMM" - we could run-time-check if the strings is one of these, otherwise fall back to "MMM D"
alternatively, afaik, we're using some js-date-formatting thing anyways (i cannot really remember for what :) - maybe we can just rely on that?
from deltachat-desktop.
khmer is ែ ថ្ងៃ, which seems wrong
i fixed that to MMM D
ukranian has "MMMM" (may this exists, idk)
MMMM D
is okay according to https://momentjscom.readthedocs.io/en/latest/moment/04-displaying/01-format/ , not sure if it is the gist, however.
so, all translations should be fine for now, however, allowing translations for that strings has still the potential to break things without us noticing, as it will happen only in some language.
so, it would be good if we can get rid of the string or do some plausibility runtime check and default to MMM D
if that fails
from deltachat-desktop.
In the mean time I changed the Russian translation.
https://app.transifex.com/delta-chat/delta-chat-app/translate/#ru/stringsxml/161513327
from deltachat-desktop.
This is should be solved now by the translations update and #3889 would remove the usage of the translations string entirely.
from deltachat-desktop.
Related Issues (20)
- no error shown when the app cannot be opened HOT 6
- Not possible to delete group image HOT 2
- handle subsequent taps on profile icon HOT 3
- small screen layout: switching account should open the chatlist HOT 1
- small screen layout: going to the chatlist unselects the chat HOT 1
- strings bug in broadcast list dialog
- layout bug in image message from self with overridden sender name
- After joining with invite link composer is still blocked
- Image cropper is not started when creating a group
- Forward Message: Search shows many placeholders
- Clickable area of the x-icon in the message details window is reduced and moved down HOT 2
- Release Progress 1.46.0 💫 HOT 2
- DeltaChat desktop flatpak 1.46.0 suddenly fails to start HOT 9
- wrong aspect ratio for images shown in quotes HOT 2
- "search in chat" on small screens looks as if not working
- add "clone group"
- show device message only once as unread
- group memberlist: just tapping pills should not clear members HOT 1
- placement of "Paste" in "Scan QR code" not obvious
- notifications are sometimes not removed from notification center [needs step to reproduce] HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deltachat-desktop.