Giter Site home page Giter Site logo

Comments (4)

r10s avatar r10s commented on July 16, 2024 1

i think, the key timestamp_format_m_desktop is very questionable at all.

translators do not really know what to do with it, i just did a grep, it is seems also wrong in at least one other language. - ukranian has "MMMM" (may this exists, idk), khmer is ែ ថ្ងៃ, which seems wrong.

all others are "MMM D" or "D MMM" - we could run-time-check if the strings is one of these, otherwise fall back to "MMM D"

alternatively, afaik, we're using some js-date-formatting thing anyways (i cannot really remember for what :) - maybe we can just rely on that?

from deltachat-desktop.

r10s avatar r10s commented on July 16, 2024 1

khmer is ែ ថ្ងៃ, which seems wrong

i fixed that to MMM D

ukranian has "MMMM" (may this exists, idk)

MMMM D is okay according to https://momentjscom.readthedocs.io/en/latest/moment/04-displaying/01-format/ , not sure if it is the gist, however.

so, all translations should be fine for now, however, allowing translations for that strings has still the potential to break things without us noticing, as it will happen only in some language.

so, it would be good if we can get rid of the string or do some plausibility runtime check and default to MMM D if that fails

from deltachat-desktop.

WofWca avatar WofWca commented on July 16, 2024

In the mean time I changed the Russian translation.

https://app.transifex.com/delta-chat/delta-chat-app/translate/#ru/stringsxml/161513327

from deltachat-desktop.

Simon-Laux avatar Simon-Laux commented on July 16, 2024

This is should be solved now by the translations update and #3889 would remove the usage of the translations string entirely.

from deltachat-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.