Giter Site home page Giter Site logo

Comments (3)

demirten avatar demirten commented on July 18, 2024

Before multiplication, modulo(1000) value used so max value can be 4294967 which is less than of unsigned int limit (4294967295)

When it comes to divide operations, if data comes from a buggy client, it is possible to get msecs greater than 1000, so I'll try to add some controls.

I'll also make improvements on twamp_time()

Thanks for your feedback.

from twamp-gui.

shabiuri avatar shabiuri commented on July 18, 2024

the problem is not the modulo, when you take a millisecond value from the system time and convert it to TWAMP time, the fraction part should be in the range of 0-2^32, this means your need to multiply the millisecond value by 4294967.296

from twamp-gui.

demirten avatar demirten commented on July 18, 2024

Fixed on commit 000fa2d

I don't changed TWAMP_FLOAT_DENOM definition because it is already used by some other parts in code. It should be ok now.

Thanks for your feedback

from twamp-gui.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.