Comments (3)
Before multiplication, modulo(1000) value used so max value can be 4294967 which is less than of unsigned int limit (4294967295)
When it comes to divide operations, if data comes from a buggy client, it is possible to get msecs greater than 1000, so I'll try to add some controls.
I'll also make improvements on twamp_time()
Thanks for your feedback.
from twamp-gui.
the problem is not the modulo, when you take a millisecond value from the system time and convert it to TWAMP time, the fraction part should be in the range of 0-2^32, this means your need to multiply the millisecond value by 4294967.296
from twamp-gui.
Fixed on commit 000fa2d
I don't changed TWAMP_FLOAT_DENOM definition because it is already used by some other parts in code. It should be ok now.
Thanks for your feedback
from twamp-gui.
Related Issues (15)
- Assets for the site
- twamp-responder doesnt run on Windows7 Pro Service Pack 1 HOT 6
- twamp not working over internet HOT 1
- Twamp client cannot get test message from twamp responder setup in public ip azure virture mahcine HOT 1
- Does the tool can implement on a Linux server to control TWAMP? HOT 2
- Not able to compile
- Responder Seems to leak memory HOT 2
- Install on two network based docker images HOT 3
- Add FAQ or "How to use twamp-GUI" to website or readme
- no response from server HOT 3
- sender and receiver ports mixed in reponder HOT 1
- responder padding handling not according to spec in reflected TWAMP-Test messages HOT 1
- Not able to open Twampclient in windows IPv6 machine
- Any plans for a CLI version? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twamp-gui.