Giter Site home page Giter Site logo

Comments (3)

dempseyatgithub avatar dempseyatgithub commented on July 17, 2024 1

This is fixed by commit 0283c5e.

The code detects if the project name conflicts with a target name and adds "-Project-Settings" to the base name of the project config files. It also alerts the user that this was done.

Thank you for reporting this! I will be closing the pull request.

from buildsettingextractor.

dempseyatgithub avatar dempseyatgithub commented on July 17, 2024

First, thanks for taking the time to write up the issue, and also for the pull request.

I'm wondering if there might be a better experience than writing nothing and an error of 'please try again'. Possibly using the default name of the Project if there is a conflict (and alerting the user at the end), and possibly using an alternate default name 'Common' if there is a conflict because the user has a target named 'Project' (and also alerting the user at the end). Or possibly just appending something to the project-level files, like '-ProjectLevel' to avoid the file name conflict and an alert explaining what happened.

Will definitely think about the different approaches.

from buildsettingextractor.

rlwimi avatar rlwimi commented on July 17, 2024

Sounds great. No worries if you want to close the PR. I usually name xcconfigs more explicitly using Target and Configuration terms themselves, since it can get hairy if you take subsequent steps to build further hierarchy after the extraction.

from buildsettingextractor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.