Giter Site home page Giter Site logo

Download Card Improvement about ytdlnis HOT 12 CLOSED

matt873 avatar matt873 commented on June 12, 2024
Download Card Improvement

from ytdlnis.

Comments (12)

deniscerri avatar deniscerri commented on June 12, 2024 2

Will consider adding different preferences for format sorting
For now im thinking

  • size
  • id
  • container type

from ytdlnis.

deniscerri avatar deniscerri commented on June 12, 2024 2

If you haven't noticed my format card is influenced by powertube.
Yes the sorting by container will have the sub-groups sorted by filesize ofc

from ytdlnis.

deniscerri avatar deniscerri commented on June 12, 2024 1

The feature is implemented. Its out on telegram

from ytdlnis.

deniscerri avatar deniscerri commented on June 12, 2024 1

Oh you are right. Yes i had forgotten

from ytdlnis.

deniscerri avatar deniscerri commented on June 12, 2024

Powertube has them grouped but the filesizes are all over the place. In my app they are sorted by filesize. As for the othrr request, it can be done

from ytdlnis.

matt873 avatar matt873 commented on June 12, 2024

Yes, they are sorted by file size but it would make the card more neat if WEBM and MPEG-4 formats are grouped into two separate groups both containing the formats in order, i.e., 1080, 720, 480, etc. Just my suggestion.

from ytdlnis.

matt873 avatar matt873 commented on June 12, 2024

Will consider adding different preferences for format sorting For now I'm thinking

  • size
  • id
  • container type

Sounds excellent. Formats arranged into their corresponding containers in ascending or descending order of resolution/size would be ideal. When implementing this, I want you to take a quick peek at the PowerTube download card to get a general sense of how it will work.

from ytdlnis.

matt873 avatar matt873 commented on June 12, 2024

Swapping the position of format sizes with format ID would have been good. What do you think of it? Was it not implemented intentionally or you forgot?

from ytdlnis.

deniscerri avatar deniscerri commented on June 12, 2024

Wdym swapping?

from ytdlnis.

matt873 avatar matt873 commented on June 12, 2024

Wdym swapping?

I think it will make video sizes in a single column on the right for easy comparison of sizes. It just feels easy on eyes as is the case with Powertube. Also, format ID should naturally be with container type and video resolution which all is technical info about the video.

from ytdlnis.

matt873 avatar matt873 commented on June 12, 2024

Is it possible to get "file already downloaded" thing in download card?

from ytdlnis.

deniscerri avatar deniscerri commented on June 12, 2024

Too many variables to check. The app already checks if u have the same download in the download queue tho

from ytdlnis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.