Giter Site home page Giter Site logo

Comments (5)

denisidoro avatar denisidoro commented on May 8, 2024 1

Thanks, @engrravijain!

These should be valid arguments: foo, foo_bar, foo-bar and foo bar.

Today, only the first two are considered valid.

First, you need to change this regex: https://github.com/denisidoro/navi/blob/master/src/arg.sh#L3.

Then, when assigning values, you need to replace spaces and dashes by underscores here, because foo-bar isn't a valid bash variable: https://github.com/denisidoro/navi/blob/master/src/main.sh#L41

from navi.

denisidoro avatar denisidoro commented on May 8, 2024 1

Ah, don't forget to start from the dev branch instead of master

from navi.

engrravijain avatar engrravijain commented on May 8, 2024

Hey @denisidoro, I would like to pick this issue up. Need some more clarification here what is the requirement exactly.

from navi.

denisidoro avatar denisidoro commented on May 8, 2024

Or another solution is to replace the dashes and spaces when reading the files. This way no other code would be modified. However, it would make the startup a little bit slower

from navi.

engrravijain avatar engrravijain commented on May 8, 2024

Got it. Thanks, Denisidoro.

from navi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.