Giter Site home page Giter Site logo

Comments (7)

not-arzuaga avatar not-arzuaga commented on August 9, 2024

Can I take this one?

from dfcomps.ru.

deniskond avatar deniskond commented on August 9, 2024

@not-arzuaga sure, I'm assigning it to you :)

from dfcomps.ru.

not-arzuaga avatar not-arzuaga commented on August 9, 2024

While I was working on this I was questioning, why did you implement an image container to then display the iframe, wouldn't it would be better to have the iframe to begin with?

from dfcomps.ru.

not-arzuaga avatar not-arzuaga commented on August 9, 2024

I can make a callback to when the iframe is shown to start/click the video, but I think it would be best to show the iframe from the beginning.

from dfcomps.ru.

deniskond avatar deniskond commented on August 9, 2024

@not-arzuaga the main problem is site performance, the main page becomes too heavy if it contains more than one youtube iframe, that's why it is optimized not to load iframe at first

from dfcomps.ru.

not-arzuaga avatar not-arzuaga commented on August 9, 2024

I sent you a pr with a possible fix, it was only nescesary that the video ended in ?autoplay=1, so I made it like if someone added it will not change the url and if not it will be added

from dfcomps.ru.

deniskond avatar deniskond commented on August 9, 2024

@not-arzuaga Thanks! that works pretty well

from dfcomps.ru.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.