Does not build on FreeBSD 9

[dennypage]

Does not build on FreeBSD 9

[rbgarga]

I've added a patch to ports tree to fix it:

https://svnweb.freebsd.org/ports/head/net/dpinger/files/patch-dpinger.c?revision=404730&view=markup

[dennypage]

Okay, thanks Renato.

Btw, I assume the ports tree doesn't allow conditional patches based on target version?

I added a temporary fix.

[rbgarga]

Didn't you like the fcntl() fix?

[dennypage]

No, your fcntl() change was just fine. I was looking at all the descriptors for close on exec and ran into other problems. The remaining issue is the file descriptor from accept(). Since accept/fcntl isn't atomic, this fd is left exposed. I would like to use accept4(), but this has some issues on some Linux systems (you have to define __USE_GNU which I don't want to do), and isn't present in older FreeBSD systems. Given that I can't fix it completely on any system, I'm going to change it back to fcntl() in all locations and revisit it in a year.

After many years of coding for maximum portability and legacy systems, I've become tired of it. I have grown to absolutely hate ifdefs. :)

[dennypage]

I've pushed an update that covers all the FDs as best as can be done with fcntl(). Please let me know if you run into any other problems. Many thanks.