Giter Site home page Giter Site logo

Comments (5)

iuioiua avatar iuioiua commented on September 26, 2024 1

Either way, I like the idea of a BrotliCompressionStream() and BrotliDecompressionStream().

from deno_std.

iuioiua avatar iuioiua commented on September 26, 2024 1

We don't want to overwrite globals. It should be an exported class, if anything.

from deno_std.

iuioiua avatar iuioiua commented on September 26, 2024

To reiterate, I suggested std/streams just so there are no blockers to getting the ball rolling with an implementation. I think such an implementation should exist in std/compress (or similar). However, more discussion is needed before committing to a whole new package.

from deno_std.

iuioiua avatar iuioiua commented on September 26, 2024

How about implementing extended versions of CompressionStream and DecompressionStream that also support br as the argument? If constructed with anything other than br, it delegates to using the runtime.

Whichever way we go, we'd gladly take a look at a PR that does this in @std/compress.

from deno_std.

BlackAsLight avatar BlackAsLight commented on September 26, 2024

How about implementing extended versions of CompressionStream and DecompressionStream that also support br as the argument? If constructed with anything other than br, it delegates to using the runtime.

Whichever way we go, we'd gladly take a look at a PR that does this in @std/compress.

You mean something like this?

self.CompressionStream = function () {
    const compressionStream = CompressionStream
    return class {
        #readable: ReadableStream<Uint8Array>
        #writable: WritableStream<Uint8Array>
        constructor(format: string) {
            const { readable, writable } = format === 'br' ? new BrotliCompressionStream() : new compressionStream(format)
            this.#readable = readable
            this.#writable = writable
        }

        get readable(): ReadableStream<Uint8Array> {
            return this.#readable
        }

        get writable(): WritableStream<Uint8Array> {
            return this.#writable
        }
    }
}()

from deno_std.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.