Comments (5)
Note: In Node.js, +0 and -0 are not equal with assert.strictEqual
assertion. I'm not sure the suggested behavior is expected
from deno_std.
That's a fair point. Should we adhere to ECMA's definition of strict equality (===
) or mimic Node's implementation, which uses Object.is()
?
from deno_std.
Jest and Vitest also follow what Node.js does. The below examples throw in jest and vitest:
Jest
expect(+0).toStrictEqual(-0);
Vitest
import { expect, test } from 'vitest'
expect(+0).toStrictEqual(-0);
from deno_std.
Ok. I'll revert and instead add a note explaining the behavior.
from deno_std.
fix(assert): handle
assertStrictEquals(-0, +0)
correctly #4715
See #4718
from deno_std.
Related Issues (20)
- feat_req(http/routes): add a accept filter HOT 1
- qol(http/route): typings and handler signature HOT 4
- suggestion: add password hashing HOT 3
- `assertEquals` is very slow for large `Set`/`Map` obj due to O(n^2) comparison algorithm HOT 6
- `assertEquals` sometimes gives wrong result for complex keys HOT 1
- Unstable APIs in stable packages should be more clearly marked as unstable HOT 8
- `pick` shouldn't pick missing keys HOT 8
- `pick` and `omit` should preserve prototype, property descriptors, and extensibility HOT 1
- Add Utility Function to Ensure Exact Number of Bytes Read from File HOT 2
- bug(net): `getNetworkAddress()` returns loopback IP on WSL2 HOT 2
- assertEquals doesn't work for large arrays HOT 3
- encodeBase64/decodeBase64 seems to be inefficient HOT 13
- bug(collection): Inconsistent behavior between `pick` and `omit`
- bug(log): `warn()` and others behave different depending on import
- `@std/fs` `exists[Sync]` Does Not Require `--allow-sys` Any More? HOT 1
- Return type of `http/getCookies` is `Record<string, string>` instead of `Record<string, string | undefined>` HOT 5
- experiment: BYO test coverage explorer HOT 9
- to-do: deprecate and remove `@std/archive`
- to-do: trim `@std/io` APIs
- `@std/http/route` is doesn't automatically route `HEAD` requests HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deno_std.