Giter Site home page Giter Site logo

Comments (6)

bartlomieju avatar bartlomieju commented on September 24, 2024

@dsherret and I also just hit it. We should revert this change and still have this command, but remove prompts for lint/unstable.

CC @nayeemrmn

from vscode_deno.

cpunktbueno1 avatar cpunktbueno1 commented on September 24, 2024

Update - This is a feature, not a bug (thanks to @irbull from Discord!)

The Initalize workspace was removed in favour of enable. edde9c6. There are no questions asked anymore, it should just update the settings.json with
{
"deno.enable": true
}

Please let me know if I should close this issue, or if it can be used as a Documentation issue as well?

Here, the old command is still referenced:
https://docs.deno.com/runtime/manual/references/vscode_deno/

Thanks!
Christian

from vscode_deno.

irbull avatar irbull commented on September 24, 2024

@dsherret and I also just hit it. We should revert this change and still have this command, but remove prompts for lint/unstable.

CC @nayeemrmn

Could probably just alias Initialize Workspace Configuration to Enable. It's a bit jarring that there are no prompts anymore, but that's actually the point.

from vscode_deno.

irbull avatar irbull commented on September 24, 2024

I was just going to push a PR, but I see you did this. I was wondering if we should add a "deprecation warning" Something like "Initialize Workspace Configuration (Deprecated)". You added that to the description, but I'm not sure where those are shown in the UI . Also, while testing this, I found it a bit jarring not to see a pop-up. I understand what is happening, but I wonder if others will be confused and wonder if the initialize actually did anything?.

from vscode_deno.

bartlomieju avatar bartlomieju commented on September 24, 2024

I think we're gonna have to leave it as is - there's a ton of references to "Initialize Workspace Configuration" in the wild.

That said, I agree about a popup - probably good to show a notification that the operation succeeded.

@nayeemrmn could you do that?

from vscode_deno.

irbull avatar irbull commented on September 24, 2024

Here is a PR that adds a modal info dialog. It might be a good stopgap measure as users were expecting an input dialog, and now we show them nothing. In a few releases (or maybe Deno 2.0) we can replace this with a message on the status bar.

#1060

from vscode_deno.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.