How to specify bash for sh files

[dense-analysis]

How to specify bash for sh files

[w0rp]

The first of your two examples looks correct to me. There is an open pull request #55 which deals with discovering the right shell to use bashed on the shebang line at the top. That should probably improve things, but I'm not quite certain about the implementation yet. I would like to avoid the systemlist call if at all possible. Take a look at that pull request.

The default shell is bash when the shell cannot be detected otherwise.

[w0rp]

Check out the branch shell-detection. I tried to improve shell detection without making a system call. I realised that there are only so many shell programs we can support with a -n flag, so I can list all of them, and the name of the shell program to run must come basically at the end of the string. You could symlink to the shell programs or something but... just don't do that.

[KabbAmine]

9d52d96 looks good to me, but you still can improve it:

• First check if there is a shebang, and if not ...
• check the environment variable $SHELL (fnamemodify($SHELL, ':t')), and if it returns an empty string...
• fallback to g:ale_linters_sh_shell_default_shell

[w0rp]

What if I change the default value of g:ale_linters_sh_shell_default_shell to fnamemodify($SHELL, ':t') or 'bash' if that string is empty? Then you will be able to override the value of $SHELL if you want to.

[KabbAmine]

Good idea, that should cover all the cases.

[w0rp]

I have pushed that now, and another commit which documents the option.

[KabbAmine]

Great.

For the issue here, its again related to the used local (Mine is french).
A PR is on the way.