Giter Site home page Giter Site logo

Comments (6)

jeremylong avatar jeremylong commented on August 29, 2024

The plugin will scan only the projects it is applied to. If you apply it to the root it will scan everything - but each project will get its own report unless you use the aggregate task

from dependency-check-gradle.

jeremylong avatar jeremylong commented on August 29, 2024

There is no contradiction. You can apply the plugin to an entire multi-project build and only scan a specific project by specifying scanProjects

from dependency-check-gradle.

jeremylong avatar jeremylong commented on August 29, 2024

Or you can only apply the plugin to a specific build. Multiple ways to achieve the same goal.

from dependency-check-gradle.

guai avatar guai commented on August 29, 2024

this line in the docs is totally misleading "scanProjects - A list of projects that will be scanned, all other projects are skipped. The list or projects to skip must include a preceding colon: scanProjects = [':app']. This is mutually exclusive with the skipProjects property."
and in reality this is a filter, what projects to include from the list of subprojects
killed half-a-day on it, then looked into sources

from dependency-check-gradle.

mgroth0 avatar mgroth0 commented on August 29, 2024

Thank you for clarifying, @jeremylong

The plugin will scan only the projects it is applied to. If you apply it to the root it will scan everything

I think this breaks idiomatic Gradle norms and is not future-proof. Gradle plugins applied to the root do not typically have a direct effect on subprojects. Also, the newset gradle versions are moving towards project isolation, which means that no projects (including the root project) should be configuring other projects like this. Sharing build logic between projects is meant to be done through plugins.

So I think there are two issues

  1. The documentation can be more clear. I can offer a documentation PR addressing where I was confused if that is helpful. I would just add a couple of sentances providing the answers you did here.
  2. Remove the ability for the root project to configure sub projects; this is needed for compatibility with project isolation in future gradle versions. Shall I create a new issue for this?

from dependency-check-gradle.

jeremylong avatar jeremylong commented on August 29, 2024

Sharing build logic between projects is meant to be done through plugins.

Do you mean conventions?

Also - if you don't mind I would love a PR to update the documentation.

from dependency-check-gradle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.