Comments (4)
Thanks for the detailed report, @jeffchiou. I know it can feel annoying to put together, but it gives me a ton of useful context.
I see the same thing on MacOS, so I think it is safe to rule out any Mac/Windows problems. As far as I can tell (and correct me if it is different for you), everything still works as it is supposed to (see below for my simple test). Is there a particular use-case you have where you need to check the installed plugins programmatically?
I suspect the root issue is related to my implementation of that "off-by-default" --annoy
option, which is the biggest addition to v0.2.2. When I register that option, it might be doing something strange to the entrypoints checks. I'd love suggestions for how to fix things; I'm not sure of the best way forward.
N.B. For 🤦 reasons explained in #78 (comment), v0.2.1 was identical to v.0.2.0.
Test
I created this dummy test.py
file.
import pandas
df = pandas.DataFrame()
When I ran flake8
, I got what I expected
$ flake8 test.py
test.py:1:1: PD001 pandas should always be imported as 'import pandas as pd'
and
$ flake8 --annoy test.py
test.py:1:1: PD001 pandas should always be imported as 'import pandas as pd'
test.py:3:1: PD901 'df' is a bad variable name. Be kinder to your future self.
from pandas-vet.
@deppen8
The use case for me checking the plugins is just making sure my flake8 plugins are working correctly. Thank you for your work - and no problem, I'm sure being a maintainer can get much more annoying at times than writing a bug report.
from pandas-vet.
This plugin should be defining parse_options
as a classmethod to receive parsed arguments as parsed by Flake8, not calling this itself.
This might be missing from the documentation but every popular plugin that adds options to Flake8 follows this API except for this one.
from pandas-vet.
This is documented though: https://flake8.pycqa.org/en/latest/plugin-development/plugin-parameters.html#accessing-parsed-options
from pandas-vet.
Related Issues (20)
- pandas-vet should run when flake-8 invoked by pre-commit HOT 1
- Automate releases to PyPI and conda-forge
- Challenging PD008: .at can be useful HOT 3
- False positive: dict().values()
- False positive: PD005 for regex `sub` method HOT 1
- New approach to docs with JupyterBook HOT 1
- Use generator expressions when possible HOT 2
- inplace set to a variable raises exception
- PD011 - shoud be to_numpy() instead of to_array()?
- Improve contributor experience HOT 1
- Constant column check with `nunique` HOT 2
- `PD012` is outdated HOT 1
- Improve official docs
- Check for proper `reset_index`
- torch.Tensor.sort return type values access PD011 false positive
- Add nox support to run tests, flake8, black locally HOT 1
- Add banners to Readme. HOT 1
- Add check for python functions that should be pandas methods
- Add notes about disabling checks to README
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pandas-vet.