Giter Site home page Giter Site logo

Comments (4)

deppen8 avatar deppen8 commented on May 29, 2024

Thanks for the detailed report, @jeffchiou. I know it can feel annoying to put together, but it gives me a ton of useful context.

I see the same thing on MacOS, so I think it is safe to rule out any Mac/Windows problems. As far as I can tell (and correct me if it is different for you), everything still works as it is supposed to (see below for my simple test). Is there a particular use-case you have where you need to check the installed plugins programmatically?

I suspect the root issue is related to my implementation of that "off-by-default" --annoy option, which is the biggest addition to v0.2.2. When I register that option, it might be doing something strange to the entrypoints checks. I'd love suggestions for how to fix things; I'm not sure of the best way forward.

N.B. For 🤦 reasons explained in #78 (comment), v0.2.1 was identical to v.0.2.0.

Test

I created this dummy test.py file.

import pandas

df = pandas.DataFrame()

When I ran flake8, I got what I expected

$ flake8 test.py 
test.py:1:1: PD001 pandas should always be imported as 'import pandas as pd'

and

$ flake8 --annoy test.py 
test.py:1:1: PD001 pandas should always be imported as 'import pandas as pd'
test.py:3:1: PD901 'df' is a bad variable name. Be kinder to your future self.

from pandas-vet.

jeffchiou avatar jeffchiou commented on May 29, 2024

@deppen8
The use case for me checking the plugins is just making sure my flake8 plugins are working correctly. Thank you for your work - and no problem, I'm sure being a maintainer can get much more annoying at times than writing a bug report.

from pandas-vet.

sigmavirus24 avatar sigmavirus24 commented on May 29, 2024

This plugin should be defining parse_options as a classmethod to receive parsed arguments as parsed by Flake8, not calling this itself.

This might be missing from the documentation but every popular plugin that adds options to Flake8 follows this API except for this one.

from pandas-vet.

sigmavirus24 avatar sigmavirus24 commented on May 29, 2024

This is documented though: https://flake8.pycqa.org/en/latest/plugin-development/plugin-parameters.html#accessing-parsed-options

from pandas-vet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.