[BUG] Fonts not bundled with release

[deref]

[BUG] Fonts not bundled with release

[brandonbloom]

My main issue was the ligatures. I wasn't aware of the toggle. Thanks for pointing that out.

We can use this font, but according to the license we must provide notice:

2) Original or Modified Versions of the Font Software may be bundled,
redistributed and/or sold with any software, provided that each copy
contains the above copyright notice and this license. These can be
included either as stand-alone text files, human-readable headers or
in the appropriate machine-readable metadata fields within text or
binary files as long as those fields can be easily viewed by the user.

We'd have to put a license in to a NOTICE.md file in the root of the repository, as well as provide some way to access it in the GUI as well. For example, see chrome://terms/or about:license in Firefox.

[brandonbloom]

That's fine too. It also requires a NOTICE entry.

[brandonbloom]

So I was about to take this off your plate & went looking to see what font we're using. Looks like Fira Code, but that's one of those weird fonts with fancy ligatures. I think folks have pretty strong preferences both in favor and against these ligatures. I don't think we should use Fira Code by default because of this.

@jwmza Can you pick a different font please?

My advice would be to select one from https://fonts.google.com/

1. Double check the license. It should be "Open Font License" (which I think is all of them on Google Fonts, but not 100% sure)
2. Select multiple styles (bold, italic, etc) as needed. See the little window/+ icon thing in the top-right corner to bring the right panel out as like a shopping cart.
3. At the bottom of that shopping cart thing, click "Download all", and just put those in the ./gui/public directory and css @import or whatever like any other embedded image.
4. Then open a PR :) and I'll help you double-check. It's probably going to be 1-5MiB of stuff, so we don't want to include that in the repo unless we're confident it's right, b/c that version will be in ever clone forever :)

[jrysana]

@brandonbloom there's a CSS toggle for ligatures on/off - Fira Code is a really good code font, license here: https://github.com/tonsky/FiraCode/blob/master/LICENSE

I think we should use Fira Code and default ligatures off with an optional switch potentially added later. Is there a reason other than ligatures you'd be against it?

[jrysana]

Sounds good, I'll get these bundled.

Presumably we are all good with "Inter" as the sans serif font of choice @brandonbloom ?
https://rsms.me/inter/ https://github.com/rsms/inter/blob/master/LICENSE.txt